Assign value to array of pointers

by

You’re allocating a new memory block of size sizeof(char*)*10 (which, assuming you want enough space for 10 characters, not 10 pointers, should be sizeof(char)*10), and then having each index in the item array point to a new block of memory in a loop. All is well and good until you overwrite where the item array points with the code item[h]=&x[0]. This makes every pointer in the item array point the same memory location (x). Just sprintf directly into the new memory instead. Also, because you’re dealing with strings, make sure to null terminate. Also, you need to make sure you don’t write more than 9 characters into your buffer of size 10. Also, unless using c strings is necessary, take chris’ advice and use std::string.

int h = 0;
char* item[6];

for (h = 0; h < 6; h++)
{
  item[h] = (char*)calloc(20,sizeof(char));
  sprintf(item[h], "item (%d)", h);
  printf("item= %s\n", item[h]);
}
for (h = 0; h < 6; h++)
{
  printf("item2= %s\n", item[h]);
}

More Related Contents:

  1. ReadFile weird behavior when buffer is CString
  2. Converting std::string from const_iterator to char*?
  3. In C++, what is a virtual base class?
  4. How do I use a custom deleter with a std::unique_ptr member?
  5. Py_Initialize fails – unable to load the file system codec
  6. How does delete[] know it’s an array?
  7. How to call erase with a reverse iterator
  8. explicit specialization of template class member function
  9. Why can’t clang with libc++ in c++0x mode link this boost::program_options example?
  10. Why do compilers allow string literals not to be const?
  11. How to use boost bind with a member function
  12. Why are lambda expressions not allowed in an unevaluated operands but allowed in the unevaluated portions of constant expressions?
  13. rvalue to lvalue conversion Visual Studio
  14. How do you determine the size of an object in C++?
  15. What is useful about a reference-to-array parameter?
  16. Converting data from glReadPixels() to OpenCV::Mat
  17. Get a file name from a path
  18. What exactly is the difference between “pass by reference” in C and in C++?
  19. How to define a string literal in gcc command line?
  20. How do I get the window handle of the desktop?
  21. vs
  22. May std::vector make use of small buffer optimization?
  23. How to enable visual styles without a manifest
  24. Determine path to registry key from HKEY handle in C++
  25. Is there a way to use C++ preprocessor stringification on variadic macro arguments?
  26. What is the difference between #define and const? [duplicate]
  27. How do I make an image resize to scale in Qt?
  28. Sorting a vector of objects by a property of the object
  29. How to use sort() in C++ with custom sort member function?
  30. How can I cin and cout some unicode text?

Leave a Comment