C++ – Printing prime numbers till N [closed]

by

First for future reference you should probably post that on code review, unless there is a specific problem then you should create a Minimal, Complete, and Verifiable post.

There is nothing inherently wrong other than you do not check that N>0 which could lead to an infinite loop, j should be going to i not N, and I think this would print 1 as a prime number which it is not. Here are some pointers:

  1. Why are you going from N to 0? That seems a little counter intuitive compared from going from 2 to N (you can skip 1 since it is not prime)

  2. If you are going to use a flag (u) then you should make it a bool which forces it to be either true or false

  3. You do not need to do a flag, instead as soon as you find a divisor print the number and then break the inner loop like

    for(j=2; j< N-1; j++){
   if(i%j==0){
     cout << i << " ";
     break;
    }
 }

  4. You do not need to have j go all the way to i, just the sqrt(i) since anything greater then the sqrt(i) that divides i must must be multiplied by some number smaller then the sqrt(i). So if i is not prime, then there must be a divisor below sqrt(i)

More Related Contents:

  1. “Prime or not” program
  2. Leading zeros of a binary number doesn’t get printed
  3. Which is the fastest algorithm to find prime numbers?
  4. Print leading zeros with C++ output operator?
  5. What is special about numbers starting with zero?
  6. What does it mean when a numeric constant in C/C++ is prefixed with a 0?
  7. Determining if a number is prime
  8. Printing prime numbers from 1 through 100
  9. OpenMP set_num_threads() is not working
  10. Fastest algorithm for primality test [closed]
  11. What is the best way to generate random numbers in C++?
  12. is it ok to specialize std::numeric_limits for user-defined number-like classes?
  13. C++ – how to find the length of an integer
  14. How do you set the cout locale to insert commas as thousands separators?
  15. Are the character digits [‘0’..’9′] required to have contiguous numeric values?
  16. Is there a way to write a large number in C++ source code with spaces to make it more readable? [duplicate]
  17. Why aren’t my include guards preventing recursive inclusion and multiple symbol definitions?
  18. Unresolved external symbol in object files
  19. Finding all the subsets of a set
  20. C++ Winsock P2P
  21. Why don’t the C or C++ standards explicitly define char as signed or unsigned?
  22. What do each memory_order mean?
  23. How to read a growing text file in C++?
  24. 5 years later, is there something better than the “Fastest Possible C++ Delegates”?
  25. When should you use the “this” keyword in C++? [duplicate]
  26. Using bts assembly instruction with gcc compiler
  27. Why sizeof int is wrong, while sizeof(int) is right?
  28. Does C have One Definition Rule like C++?
  29. Why does pointer to int convert to void* but pointer to function convert to bool?
  30. Error: undefined reference to `sqlite3_open’

Leave a Comment