C++ : Unable to read from large txt file [closed]

by

Your problem is in the merge function:

you exceed the local variable c.

long c[30];

maybe there are more problems, that is the first I notice.

EDIT

Try this: find the differences…

#include <map>
#include <vector>
#include <fstream> 
#include <iostream> 
#include <time.h>
using namespace std;

void merge(vector<long> &,long ,long , long );


void divide(vector<long> &arr,long min, long max){
    long mid;

    if(min<max){
        mid=(min+max)/2;
        if(min != mid) divide(arr,min,mid);
        if(max != mid+1) divide(arr,mid+1,max);
        merge(arr,min,mid,max);
    }
    return;

}

void merge(vector<long> &arr,long min, long mid,long max){
    long i,j,k;
    map<long,long> c; //uses map because the vector not always start from 0
    //other option is to use vector<long> c(max-min) and substruct min when copy to/from it.
    //like this: vector<long> c(1+max-min); //initialize size = max-min+1
    //           c[k-min] = arr[i];
    //           arr[i] = c[i-min];
    i=min,j=mid+1;
    k=min;

    while(i<=mid && j<=max){
        if(arr[i]<arr[j]){
            c[k]=arr[i];
            i++;
            k++;
        }
        else{
            c[k]=arr[j];
            j++;
            k++;
        }
    }
    while(i<=mid){
        c[k]=arr[i];
        i++;
        k++;
    }
    while(j<=max){
        c[k]=arr[j];
        j++;
        k++;
    }

    for(long i=min;i<=max;i++)
        arr[i]=c[i];
}

void create_input(int i){
    srand(time(NULL));
    ofstream fout("sample2.txt");
    while(i--){
        fout<<rand()<<" ";
    }
} 

int main(){

    vector<long> data;
    long tmp;
    long count=0;
    //create random input
    //create_input(31);

    ifstream fin("sample2.txt");

    while(fin >> tmp)
    {
        data.push_back(tmp);
        count++;//count = data.size(); !!
    }
    cout<<"the unsorted array is\n";
    for(long i=0;i<count;i++)
        cout<<i<<"]\t"<<data[i]<<"\n";

    divide(data,0,count-1);//use last index not size

    cout<<"the sorted array is\n";
    for(long i=0;i<count;i++)
        cout<<i<<"]\t"<<data[i]<<"\n";


    return 0;
}

More Related Contents:

  1. How can I insert element to vector instead the element already exists in the vector?
  2. Using arrays or std::vectors in C++, what’s the performance gap?
  3. Concatenating two std::vectors
  4. Is this behavior of vector::resize(size_type n) under C++11 and Boost.Container correct?
  5. Creating an input stream from constant memory
  6. How to initialize std::vector from C-style array?
  7. How to read a binary file into a vector of unsigned chars
  8. sizeof() a vector
  9. How to cin values into a vector
  10. What is the simplest way to convert array to vector?
  11. pop_back() return value?
  12. How to implement 2D vector array?
  13. std::vector, default construction, C++11 and breaking changes
  14. Initial capacity of vector in C++
  15. How can I use something like std::vector?
  16. std::vector iterator invalidation
  17. How do you copy the contents of an array to a std::vector in C++ without looping?
  18. How to read groups of integers from a file, line by line in C++
  19. How to make elements of vector unique? (remove non adjacent duplicates)
  20. Compile time triggered range check for std::vector
  21. Why would I prefer using vector to deque
  22. What do I need to do before deleting elements in a vector of pointers to dynamically allocated objects?
  23. How do I pass multiple ints into a vector at once?
  24. Does clearing a vector affect its capacity?
  25. Can std::vector emplace_back copy construct from an element of the vector itself?
  26. How to create a vector of user defined size but with no predefined values?
  27. Difference between vector::begin() and std::begin()
  28. Why does using push_back on a vector declared with size result in a vector of zeros?
  29. Appending std::vector to itself, undefined behavior?
  30. What happen to pointers when vectors need more memory and realocate memory?

Leave a Comment