I had issue in below mention program to assign a value to the pointer.String concatenation Program( *s1=*s2) [closed]

by

So you are getting access voilation….

The problem is that your buffers are probably overflowing and you have no length check in your code…

The buffers you have allocated are only 25 bytes long

char str1[25], str2[25];

so to intruduce a length check, add an extra parameter to concat which tells how long the output buffer is, like this

void concat(char *s1, char *s2, int len){
    // Checking Null character
    while (*s1 != '\0' && len > 0)
        s1++, len--;
    //Checking Null character
    while (*s2 != '\0' && len > 0)
    {
        *s1 = *s2; //<-- Getting error in this line        
        s1++;
        s2++;
        len--;
    }
    if (len > 0) // only set the null terminator if we have space
       *s1 = '\0';
}

an then call it as this

concat(str1, str2, 25);

An then also read the man page for strncat

More Related Contents:

  1. What is the output of the following code in C? [closed]
  2. pointer to string concept in c [closed]
  3. C prog. Pointers and strings [closed]
  4. What does sizeof(&array) return?
  5. Using the equality operator == to compare two strings for equality in C [duplicate]
  6. Modifying C string constants? [duplicate]
  7. Reversing a string in C
  8. Difference between char *str=”STRING” and char str[] = “STRING”?
  9. C – Difference between “char var[]” and “char *var”?
  10. Why doesn’t scanf need an ampersand for strings and also works fine in printf (in C)?
  11. Literal string initializer for a character array
  12. Segmentation fault occurring when modifying a string using pointers?
  13. How to call function through its address in C
  14. C Programming: malloc() inside another function
  15. Initializing a pointer in a separate function in C
  16. Why does the arrow (->) operator in C exist?
  17. Hexadecimal string to byte array in C
  18. C – why is strcpy() necessary
  19. Need of Pointer to pointer
  20. Why does streaming a char pointer to cout not print an address?
  21. using printf to print out floating values
  22. Convert double/float to string
  23. In C, why can’t I assign a string to a char array after it’s declared?
  24. Is it possible to allocate array inside function and return it using reference?
  25. Scope of (string) literals
  26. C string append
  27. Dereference void pointer
  28. How to allocate the array before calling strcpy?
  29. Can a “container_of” macro ever be strictly-conforming?
  30. Difference between pointer to pointer and pointer to array?

Leave a Comment