Last word is Failing …?

by

Try this:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

FILE *fr; 

int main (int argc, const char * argv[]){
  char line[1024];
  double uppercase = 0, lowercase = 0;
  int x = 0;
  fr = fopen ("PercenUpLow.txt", "rt");
  if (fr == NULL) {
    printf ("Can't open file") ;
    return EXIT_FAILURE ;
  }
  while(fgets(line, 1024, fr) != NULL) {
    do {
      if ((line[x] >= 'A') && (line[x] <= 'Z')){
        uppercase += 1;
      }else if ((line[x] >= 'a') && (line[x] <= 'z')){
        lowercase += 1;    
      }
      x+=1;
    } while (line[x] != '\n' && line[x] != 0);

    printf("lowercase: %0.2f ", (lowercase / x) * 100);
    printf("uppercase: %0.2f \n", (uppercase / x) * 100);
    lowercase = 0;
    uppercase = 0;
    x = 0;
  }    
  return EXIT_SUCCESS;
}

I changed this line:

     } while (line[x] != '\n' && line[x] != 0);

If the file is not terminated by a \n, then the last line read is not terminated by a \n either (seems obvious) and you are reading further than the end of the line, leading to undefined behaviour.

I also test if the file could be opened correctly.

You should definitely learn how to use a debugger.

More Related Contents:

  1. C/SDL – Segmentation fault when program run multiple times in succession [closed]
  2. Segmentation fault, I don’t know why
  3. Seg fault on code that should work according to the professor [duplicate]
  4. my code does not work and I don’t know why ;-;
  5. Why do I get a segmentation fault with strcmp [closed]
  6. Why do I get a segmentation fault when writing to a “char *s” initialized with a string literal, but not “char s[]”?
  7. Crash or “segmentation fault” when data is copied/scanned/read to an uninitialized pointer
  8. Why is this string reversal C code causing a segmentation fault? [duplicate]
  9. What is a bus error? Is it different from a segmentation fault?
  10. Why does this code segfault on 64-bit architecture but work fine on 32-bit?
  11. segmentation fault using scanf [duplicate]
  12. Execution of printf() and Segmentation Fault
  13. What is the difference between a segmentation fault and a stack overflow?
  14. C – Segmentation Fault with strcmp?
  15. Getting Segmentation Fault
  16. casting char[][] to char** causes segfault?
  17. Segmentation Fault before main
  18. Segmentation Fault in strcpy()
  19. strtok segmentation fault
  20. Segmentation Fault While Creating Large Arrays in C
  21. Returning this pointer from a function
  22. SegFault after scanf?
  23. segfault only when NOT using debugger
  24. Why is strtok causing a segmentation fault?
  25. What is the simplest standard conform way to produce a Segfault in C?
  26. Segmentation fault in btree implementation
  27. strlen not checking for NULL
  28. Segmentation fault when allocating large arrays on the stack
  29. Why doesn’t my program seg fault when I dereference a NULL pointer inside of malloc?
  30. strncpy leading to segmentation fault

Leave a Comment