Long condition C++ [closed]

by

I do not know whether this solution is more efficient, but maybe it is more readable and easier to code:

#include <iostream>
#include <cstdlib>

int main()
{
    const int magicNumber = 32640;
    const int maxOffset = 1920;

    int n;
    std::cin >> n;

    int y = 20;

    const std::div_t divresult = std::div(n, magicNumber);

    if (divresult.rem > 0 && divresult.rem < maxOffset &&       // (#1)
            divresult.quot >= 1 && divresult.quot <= 10)    {   // (#2)
        y = 40;
    }

    std::cout << "y: " << y << std::endl;

    return 0;
}

EDIT:

Here, I make use of the fact that for your condition to be true, your variable to test (n) has to be between multiples of 32640 or magicNumber and multiples of that number plus some offset (maxOffset). This is the remainder of dividing your variable by the magicNumber, cf. (#1).

But this is not valid for every integer, but only for certain multiples, as expressed by the || in your original solution. In my solution, this is expressed by the quotient, cf. (#2).

While programming this answer, I learned that there is a function std::div that computes these two in one step and returns them in a structure of type std::div_t, so you can use the two members in the condition. Here you can find more information on this function.

More Related Contents:

  1. Loops in loops and increment staying at 0 in C++ [closed]
  2. Operator precedence and operator associativity rules in c++ [duplicate]
  3. Can you use 2 or more OR conditions in an if statement? [duplicate]
  4. Pointer expressions: *ptr++, *++ptr and ++*ptr
  5. Why Switch/Case and not If/Else If?
  6. Why is ++i considered an l-value, but i++ is not?
  7. How to compare multiple strings inside an if statement?
  8. What is the difference between pre-increment and post-increment in the cycle (for/while)?
  9. bool operator ++ and —
  10. Resetting the State of a Stream
  11. Prefix/Postfix increment operators
  12. What is the difference between if (NULL == pointer) vs if (pointer == NULL)?
  13. Need help on C programming -> pointer
  14. #pragma once vs include guards? [duplicate]
  15. Sleep for milliseconds
  16. OpenGL object in C++ RAII class no longer works
  17. How is std::function implemented?
  18. What’s your favorite profiling tool (for C++) [closed]
  19. What is this smiley-with-beard expression: “”?
  20. What is the first (int (*)(…))0 vtable entry in the output of g++ -fdump-class-hierarchy?
  21. Correct printf format specifier for size_t: %zu or %Iu?
  22. Custom manipulator for C++ iostream
  23. Efficiency of the STL priority_queue
  24. Optimization of raw new[]/delete[] vs std::vector
  25. How is it possible (if it is) to implement shared_ptr without requiring polymorphic classes to have virtual destructor?
  26. Finding “dead code” in a large C++ legacy application [closed]
  27. What is the NDEBUG preprocessor macro used for (on different platforms)?
  28. When must you pass io_context to boost::asio::spawn? (C++)
  29. How to create a vector of user defined size but with no predefined values?
  30. How to tell if a lib was compiled with /mt or /md?

Leave a Comment