Random number in long range, is this the way?

by

Why don’t you just generate two random Int32 values and make one Int64 out of them?

long LongRandom(long min, long max, Random rand) {
    long result = rand.Next((Int32)(min >> 32), (Int32)(max >> 32));
    result = (result << 32);
    result = result | (long)rand.Next((Int32)min, (Int32)max);
    return result;
}

Sorry, I forgot to add boundaries the first time. Added min and max params. You can test it like that:

long r = LongRandom(100000000000000000, 100000000000000050, new Random());

Values of r will lie in the desired range.

EDIT: the implementation above is flawed. It’s probably worth it to generate 4 16-bit integers rather than 2 32-bit ones to avoid signed-unsigned problems. But at this point the solution loses its elegancy, so I think it’s best to stick with Random.NextBytes version:

long LongRandom(long min, long max, Random rand) {
    byte[] buf = new byte[8];
    rand.NextBytes(buf);
    long longRand = BitConverter.ToInt64(buf, 0);

    return (Math.Abs(longRand % (max - min)) + min);
}

It looks pretty well in terms of value distribution (judging by very simple tests I ran).

More Related Contents:

  1. sort in Ascending Order [closed]
  2. How to get DateTime from the internet?
  3. Using a custom type discriminator to tell JSON.net which type of a class hierarchy to deserialize
  4. How does one configure HttpClient not to automatically redirect when it receives a 301 HTTP Status Code?
  5. Convert an int to bool with Json.Net [duplicate]
  6. Does not contain a constructor that takes 0 arguments
  7. C# 4.0 optional out/ref arguments
  8. HttpClient vs HttpWebRequest
  9. Best ORM to use with C# 4.0 [closed]
  10. Converting a LEFT OUTER JOIN to Entity Framework
  11. TPL TaskFactory.FromAsync vs Tasks with blocking methods
  12. Entity Framework and forced Inner Join
  13. How to create a method at runtime using Reflection.emit
  14. Drag-and-Drop multiple Attached File From Outlook to C# Window Form
  15. C# Find Duplicate Values in a Datatable
  16. Change ImageButton Drawable automatically
  17. How to generate a random, unique, alphanumeric string?
  18. How can I generate random alphanumeric strings?
  19. Generate random numbers uniformly over an entire range
  20. random.seed(): What does it do?
  21. Why isn’t there generic variance for classes in C# 4.0?
  22. Generate a random date between two other dates
  23. How to generate random number in Bash?
  24. C# ‘dynamic’ cannot access properties from anonymous types declared in another assembly
  25. from data table, randomly select one row per group
  26. UPDATE all records with a random number from a range
  27. Connecting to Oracle Database through C#?
  28. Generate cryptographically secure random numbers in php
  29. How does srand relate to rand function?
  30. How do I run parallel threads of computation on a partitioned array?

Leave a Comment