Switch statement fall-through…should it be allowed? [closed]

by

It may depend on what you consider fallthrough. I’m ok with this sort of thing:

switch (value)
{
  case 0:
    result = ZERO_DIGIT;
    break;

  case 1:
  case 3:
  case 5:
  case 7:
  case 9:
     result = ODD_DIGIT;
     break;

  case 2:
  case 4:
  case 6:
  case 8:
     result = EVEN_DIGIT;
     break;
}

But if you have a case label followed by code that falls through to another case label, I’d pretty much always consider that evil. Perhaps moving the common code to a function and calling from both places would be a better idea.

And please note that I use the C++ FAQ definition of “evil”

More Related Contents:

  1. Why should a function have only one exit-point? [closed]
  2. How to customize / style a UIPopoverController
  3. Should ‘if’ statement always have an ‘else’ clause? [closed]
  4. pythonic way to do something N times without an index variable? [duplicate]
  5. Switch statements are bad? [closed]
  6. What was the strangest coding standard rule that you were forced to follow? [closed]
  7. Stop PhpStorm from aligning associative arrays
  8. What kind of prefix do you use for member variables?
  9. What’s the best way to convert a number to a string in JavaScript?
  10. C# switch statement limitations – why?
  11. return statement vs exit() in main()
  12. Setting variable to NULL after free
  13. Multiple cases in switch statement
  14. Is there any benefit to this switch / pattern matching idea?
  15. SQL Switch/Case in ‘where’ clause
  16. Does anyone still use [goto] in C# and if so why? [closed]
  17. Why switch is faster than if
  18. Is ‘switch’ faster than ‘if’?
  19. sizeof with a type or variable
  20. In Python, is it better to use list comprehensions or for-each loops?
  21. Variable definition inside switch statement
  22. Two ways of currying in Scala; what’s the use-case for each?
  23. When should you use the “this” keyword in C++? [duplicate]
  24. How many constructor arguments is too many? [closed]
  25. Iterate through a C++ Vector using a ‘for’ loop
  26. Why is it recommended to have empty line in the end of a source file?
  27. For a boolean field, what is the naming convention for its getter/setter?
  28. Android coding with switch (String)
  29. Why do I get a “variable might not have been initialized” compiler error in my switch block?
  30. Is it correct to use single quotes for HTML attributes?

Leave a Comment