Yes* Yes, usually (and in your case) it does break out of the loop and returns from the method. An Exception One exception is that if there is a finally block inside the loop and surrounding the return statement then the code in the finally block will be executed before the method returns. The finally … Read more
You did a great job with your level of commenting, style, and the program layout. Some of the best I’ve seen on SO. Overall, a good effort. However, there were bugs. I’ve produced an annotated version of your code and a refactored one. See below. There were a number of bugs throughout the code, not … Read more
Why Infinite loop? Infinite loop is because of self loop in your list after calling swap() function. In swap() code following statement is buggy. (*b)->next = (temp1)->next; Why?: Because after the assignment statement in swap() function temp1‘s next starts pointing to b node. And node[b]‘s next point to itself in a loop. And the self … Read more
Node next = tmp.next; while(tmp != null){ So what happens when tmp == null? You almost got it, though. Node before = null; Node tmp = head; while (tmp != null) { Node next = tmp.next; tmp.next = before; before = tmp; tmp = next; } head = before; Or in nicer (?) naming: Node … Read more
Any alternative? No, this is as simple as it gets, and there’s no fundamentally-different way of doing it. This algorithm is already O(n) time, and you can’t get any faster than that, as you must modify every node. It looks like your code is on the right track, but it’s not quite working in the … Read more
I’ve debugged this for you. Fixes: In list_insertn, replace the entire if statement after the “If we exceed list length append at the end” comment with: if(list == NULL){ return list_insert_tail(list, input); } In list_remove, replace the test after the “We check to see if they have the same data” comment with: if(strcmp(list->data, input) == … Read more