When should your destructor be virtual? [duplicate]

by
  1. You need virtual destructor when at
    least one of class methods is
    virtual.

This is because the reason for virtual method is that you want to use polymorphism. Meaning you will call a method on the base class pointer and you want the most derived implementation – this is the whole point of polymorphism.

Now if you did not have virtual destructor and through the pointer to base class you call destructor you end up calling base class destructor. In this case you want polymorphism to work on your destructor as well, e.g. through calling destructor on your base class you want to end up calling destructor of your most derived class not your base class. 

class A
{
   virtual void f() {}
   ~A() {}
}

class B : public A
{
   void f() {}
   ~B() {}
}

A * thing = new B();
thing->f(); // calls B's f()
delete thing; // calls ~A(), not what you wanted, you wanted ~B()

having ~A() virtual turns on polymorphism

virtual ~A() {}

So when you now call

delete thing;

~B() will be called.

You would declare virtual destructors when you design class as an interface e.g. you expect it to be extended or implemented. A good practice in that case is to have a interface class (in the sense of Java interfaces) with virtual methods and virtual destructor and then have concrete implementation classes.

You can see that STL classes don’t have virtual destructors so they are not supposed to be extended (e.g. std::vector, std::string …). If you extend std::vector and you call destructor on base class via pointer or reference you will definitely not call your specialized class destructor which may lead to memory leaks.

More Related Contents:

  1. When to use virtual destructors?
  2. Why should I declare a virtual destructor for an abstract class in C++?
  3. Virtual destructor and undefined behavior
  4. Are virtual destructors inherited?
  5. Should every class have a virtual destructor?
  6. CPP- I am getting Segmentation fault (core dumped)?
  7. How to get values and save them to use later on Arduino?
  8. Why does C++ code for testing the Collatz conjecture run faster than hand-written assembly?
  9. Generating random integer from a range
  10. C++ display stack trace on exception
  11. How can I clear console
  12. How do I pass a unique_ptr argument to a constructor or a function?
  13. GCC -fPIC option
  14. Getting the high part of 64 bit integer multiplication
  15. What are the rules for the “…” token in the context of variadic templates?
  16. Difference between pointer to a reference and reference to a pointer
  17. Dead code detection in legacy C/C++ project [closed]
  18. Code::Blocks – how to compile multiple source files
  19. Override compile flags for single files
  20. What is the performance cost of having a virtual method in a C++ class?
  21. Why is iterating though `std::vector` faster than iterating though `std::array`?
  22. std::lexical_cast – is there such a thing?
  23. C++ Multi-line comments using backslash
  24. libgmp-10.dll is missing
  25. Idiomatic Way to declare C++ Immutable Classes
  26. What are differences between std::string and std::vector?
  27. Where can I get windows.h for Mac?
  28. Is it possible to write an agile Pimpl in c++?
  29. C++ forwarding reference and r-value reference
  30. Does the standard mandate an lvalue-to-rvalue conversion of the pointer variable when applying indirection?

Leave a Comment