Why the logical operators are not working as expected? [closed]

by

In your code,

 if (number == 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 ||18 || 19)

is a wrong approach. You cannot chain the logical operator like that.

As of now, because of the operator precedence, your code is essentially

if ( (number == 10) || 11 || 12 || 13 || 14 || 15 || 16 || 17 ||18 || 19)

which evaluates to either

  • if ( 1 || 11 || 12 || 13 || 14 || 15 || 16 || 17 ||18 || 19)

or

  • if ( 0 || 11 || 12 || 13 || 14 || 15 || 16 || 17 ||18 || 19)

both of which will yield a TRUE value.

You have to use it like

if ((number == 10) || (number ==  11)||(number ==  12).....

As I can see, you’re already using the switch statement, so the if check can be removed altogether. You need to add a default case to handle other numbers. You can add nested switch to get the things done.

More Related Contents:

  1. What is my C code not printing # in staircase pattern, this is from hackerrank, I did not pass all test cases, but i can't point out why?
  2. Can you tell me specific what this program is doing? [closed]
  3. Cascaded and nested if statements in C programming language
  4. break statement doesn’t work in a loop [closed]
  5. (Function) Swaping two numbers in c
  6. warning: suggest parentheses around assignment used as truth value [closed]
  7. Why does >= operator work as > operator in C when compared with 0.9 [duplicate]
  8. C: What is the output of the following code? And please explain [duplicate]
  9. Is (4 > y > 1) a valid statement in C++? How do you evaluate it if so?
  10. What is short-circuit evaluation in C?
  11. !! c operator, is a two NOT?
  12. Logical Operators in C
  13. “&&” and “and” operator in C
  14. Compound condition in C: if (0.0 < a < 1.0)
  15. Why isn’t “k” incremented in the statement “m = ++i && ++j || ++k” when “++i&&++j” evaluates to true? [duplicate]
  16. If statements not working?
  17. C programming – Loop until user inputs number scanf
  18. How to print a int64_t type in C
  19. How to output the AST built using ANTLR?
  20. Syscall implementation of exit()
  21. Checking return value of a function without return statement
  22. Does gcc automatically initialize static variables to zero?
  23. Why a pointer + 1 add 4 actually
  24. Try catch statements in C
  25. How to extract numbers from string in c?
  26. Are there alternate implementations of GNU getline interface?
  27. Does Function pointer make the program slow?
  28. Why is it assumed that send may return with less than requested data transmitted on a blocking socket?
  29. *nix select and exceptfds/errorfds semantics
  30. assigning more than one character in char

Leave a Comment