(0 == variable) or (null == obj): An outdated practice in C#? [duplicate]

by

No, there’s no need for this, because the problem it tries to avoid – namely the typo of:

if (variable = 0)

wouldn’t compile in C# anyway. The conditions in if statements have to be Boolean. There’s still a risk of making one of these mistakes:

if (something = true)
if (something = false)

if something is a Boolean variable, but the better way to fix this is to avoid the constant:

if (something)
if (!something)

If you have developers bringing over idioms like this from other languages without thinking about whether they’re appropriate in C#, you should keep an eye for them doing more of the same. If you try to write C# as if it’s C++ (or any other language, pretty much – with the possible exception of VB.NET) you’ll end up writing non-idiomatic C# code.

EDIT: As cletus noted, there is another potential area for concern:

bool a = false, b = true; 
if (a = b) { } // No warnings

So the error can still occur – but then we’re outside the realm of comparing with a constant anyway 🙂 I’d say this crops up incredibly rarely, and isn’t worth too much time spent worrying about it.

More Related Contents:

  1. Should I use public properties and private fields or public fields for data?
  2. Does anyone still use [goto] in C# and if so why? [closed]
  3. Order of items in classes: Fields, Properties, Constructors, Methods
  4. Why does StyleCop recommend prefixing method or property calls with “this”?
  5. Method Overloading with different return type [duplicate]
  6. How to loop through all enum values in C#? [duplicate]
  7. Why is a Dictionary “not ordered”?
  8. How can I automatically filter out soft deleted entities with Entity Framework?
  9. When should TaskCompletionSource be used?
  10. Best way to read a large file into a byte array in C#?
  11. Why use the C# class System.Random at all instead of System.Security.Cryptography.RandomNumberGenerator?
  12. Am I misunderstanding LINQ to SQL .AsEnumerable()?
  13. When is optimization premature? [closed]
  14. Class with indexer and property named “Item”
  15. Can the C# interactive window interact with my code?
  16. Select either a file or folder from the same dialog in .NET
  17. How to suppress a dialog box displayed by code that I can’t change?
  18. How do I do logging in C# without using 3rd party libraries? [closed]
  19. Serializing null in JSON.NET
  20. i have to access/commit/update SVN repository in WPF application using SVN API or libraries [closed]
  21. Best way to check for nullable bool in a condition expression (if …) [closed]
  22. How can I clear event subscriptions in C#?
  23. How to declare a local variable in Razor?
  24. How can I wrap text in a label using WPF?
  25. LINQ performance FAQ
  26. Allocating more than 1,000 MB of memory in 32-bit .NET process
  27. Why does null need an explicit type cast here? [duplicate]
  28. LINQ Using Max() to select a single row
  29. When exactly does .NET Monitor go to kernel-mode?
  30. What does “Beta: Use Unicode UTF-8 for worldwide language support” actually do?

Leave a Comment