Android Click on listItem checks wrong checkbox

by

Mayra is right – the problem has to do with the way the ListView is reusing your views. It’s not as if there are 9 instances of the CheckedTextView object, one per view. Instead, there’s a single one that is reused in all the rows. Thus you can’t rely on the CheckedTextView object to hold the state of whether an item is checked. You’ll need some additional data structure to hold whether a given row is checked For instance,

ArrayList<Boolean> checkedStates = new ArrayList<Boolean>();

Where the ith element is true iff the ith row should be checked. Then within your itemClickListener:

lv.setOnItemClickListener(new OnItemClickListener() {
        @Override
        public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
            boolean currentlyChecked = checkedStates.get(position);
            checkedStates.set(position, !currentlyChecked);
            // Refresh the list
        }
    });

Then within your view code:

public View getView(int pos, View inView, ViewGroup parent) {
    View v = inView;
    if (v == null) {
        LayoutInflater inflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
        v = inflater.inflate(R.layout.image_list, null);
    }

    this.c.moveToPosition(pos);

    final TextView bTitle = (TextView) v.findViewById(R.id.btitle);
    String bookmark = this.c.getString(this.c.getColumnIndex(Browser.BookmarkColumns.TITLE));


    byte[] favicon = this.c.getBlob(this.c.getColumnIndex(Browser.BookmarkColumns.FAVICON));

    if (favicon != null) {
        ImageView iv = (ImageView) v.findViewById(R.id.bimage);
        iv.setImageBitmap(BitmapFactory.decodeByteArray(favicon, 0, favicon.length));
    }
    bTitle.setText(bookmark);


    // Change the state of the checkbox to match that of the row's checked state.
    // This check box item is reused for every row, so we need to reset its state each
    // time the row is rendered.
    CheckedTextView markedItem = (CheckedTextView) view.findViewById(R.id.btitle);
    markedItem.setChecked(checkedStates.get(pos));


    return (v);
}

This should solve your problem. An alternative approach would be to move the logic of whether the row is checked or not into the domain object that the row represents. That would be my preference.

More Related Contents:

  1. Android SQLite data display to ListView
  2. Android ListView with different layouts for each row
  3. Getting an issue while checking the dynamically generated checkbox through list view
  4. How to create a closed (circular) ListView?
  5. Changing background color of ListView items on Android
  6. Listview click to show image in ImageView
  7. How to handle ListView click in Android
  8. notifyDataSetChange not working from custom adapter
  9. How to implement a view holder?
  10. What is the benefit of ViewHolder pattern in android?
  11. Redraw a single row in a listview [duplicate]
  12. How to get all checked items from a ListView?
  13. update listview dynamically with adapter
  14. How to remove all listeners added with addTextChangedListener
  15. Detecting which selected item (in a ListView) spawned the ContextMenu (Android)
  16. Android listview row delete animation
  17. Android: how to refresh ListView contents?
  18. What’s the purpose of item-id’s in Android ListView Adapter?
  19. Displaying Contact Number and Contact Name in a custom list view
  20. Custom font for Android listview
  21. OnItemClickListener and OnClickListener not working for ListView
  22. How to dynamically remove items from ListView on a button click?
  23. Why is ListView.getCheckedItemPositions() not returning correct values?
  24. Android: Why does long click also trigger a normal click?
  25. Disappearing divider in ListView when ArrayAdapter.isEnabled returns false
  26. how to detect Android ListView Scrolling stopped?
  27. android: how to delete a row from a ListView with a delete button in the row
  28. ListView: setItemChecked only works with standard ArrayAdapter – does NOT work when using customized ArrayAdapter?
  29. Checkbox auto call onCheckedChange when listview scroll?
  30. System services not available to Activities before onCreate?

Leave a Comment