Are circular class dependencies bad from a coding style point of view? [closed]

by

In general, I would call circular dependencies a Code Smell. Note that the term ‘Code Smell’ mainly indicates that ‘here is a piece of code that requires special attention, and is likely to benefit from redesign.’

In most cases I would strongly consider a design where a circular dependency is not necessary, but in rare cases it may be okay.

In your example, the ConnFactory seems redundant, but that may be because your example has been trimmed down. It seems to me, however, that the Connection creation logic would be better if it was moved to the DBInfo class. When you already have a class that contains data about a database, it seems only natural to make it responsible for creating a connection to that database.

More Related Contents:

  1. What does it mean to “program to an interface”?
  2. Prefer composition over inheritance?
  3. Try to describe polymorphism as easy as you can [closed]
  4. Pass by reference or pass by value? [closed]
  5. What’s the point of OOP?
  6. Allen Holub wrote “You should never use get/set functions”, is he correct? [duplicate]
  7. Fluent Interfaces – Method Chaining
  8. What is the use/advantage of function overloading?
  9. What is the difference between concurrency and parallelism?
  10. Why shouldn’t I use “Hungarian Notation”?
  11. Expression Versus Statement
  12. Are there any legitimate use-cases for “goto” in a language that supports loops and functions?
  13. Singletons: good design or a crutch? [closed]
  14. Conventions for exceptions or error codes [closed]
  15. Test loops at the top or bottom? (while vs. do while) [closed]
  16. What are the lesser known but useful data structures?
  17. Why is it recommended to have empty line in the end of a source file?
  18. What’s the best name for a non-mutating “add” method on an immutable collection? [closed]
  19. Are exceptions really for exceptional errors? [closed]
  20. Generate colors between red and green for a power meter?
  21. Calculating a 2D Vector’s Cross Product
  22. What’s the shortest code to cause a stack overflow? [closed]
  23. Hash Code and Checksum – what’s the difference?
  24. In what situations is octal base used?
  25. When should a method be static?
  26. Code Golf: Conway’s Game of Life
  27. Why would a language NOT use Short-circuit evaluation?
  28. How do you explain OO to new programmers? [closed]
  29. Finding closest match in collection of numbers [closed]
  30. Is there a known implementation of an indexed linked list?

Leave a Comment