Are “while(true)” loops so bad? [closed]

by

I wouldn’t say it’s bad – but equally I would normally at least look for an alternative.

In situations where it’s the first thing I write, I almost always at least try to refactor it into something clearer. Sometimes it can’t be helped (or the alternative is to have a bool variable which does nothing meaningful except indicate the end of the loop, less clearly than a break statement) but it’s worth at least trying.

As an example of where it’s clearer to use break than a flag, consider:

while (true)
{
    doStuffNeededAtStartOfLoop();
    int input = getSomeInput();
    if (testCondition(input))
    {
        break;
    }
    actOnInput(input);
}

Now let’s force it to use a flag:

boolean running = true;
while (running)
{
    doStuffNeededAtStartOfLoop();
    int input = getSomeInput();
    if (testCondition(input))
    {
        running = false;
    }
    else
    {
        actOnInput(input);
    }
}

I view the latter as more complicated to read: it’s got an extra else block, the actOnInput is more indented, and if you’re trying to work out what happens when testCondition returns true, you need to look carefully through the rest of the block to check that there isn’t something after the else block which would occur whether running has been set to false or not.

The break statement communicates the intent more clearly, and lets the rest of the block get on with what it needs to do without worrying about earlier conditions.

Note that this is exactly the same sort of argument that people have about multiple return statements in a method. For example, if I can work out the result of a method within the first few lines (e.g. because some input is null, or empty, or zero) I find it clearer to return that answer directly than to have a variable to store the result, then a whole block of other code, and finally a return statement.

More Related Contents:

  1. I don't know what's wrong with the do-while loop
  2. Repeat the “if” statement if it has to go to the “else” statement
  3. How to print print the first and last numbers from the list do while loop
  4. Java – What would cause a while-loop to execute, even when false?
  5. What is a NumberFormatException and how can I fix it?
  6. Declaring variables inside or outside of a loop
  7. How to get out of while loop in java with Scanner method “hasNext” as condition?
  8. Timer & TimerTask versus Thread + sleep in Java
  9. How do I exit a while loop in Java?
  10. Java for loop vs. while loop. Performance difference?
  11. Java: for(;;) vs. while(true)
  12. How to use .nextInt() and hasNextInt() in a while loop
  13. Scanner input validation in while loop
  14. Whats wrong with this while loop? [duplicate]
  15. when to use while loop rather than for loop
  16. Java How can I break a while loop under a switch statement?
  17. Does Java recognize infinite loops?
  18. How to optimize for-comprehensions and loops in Scala?
  19. Java – Does returning a value break a loop?
  20. Java InputMismatchException
  21. Run code for x seconds in Java?
  22. Call a method with parameters in java
  23. How do I correctly implement this code segment without getting a logic error? [closed]
  24. Concatenating null strings in Java [duplicate]
  25. POSTing a @OneToMany sub-resource association in Spring Data REST
  26. Spring – Is it possible to use multiple transaction managers in the same application?
  27. Accessing Java static final variable value through reflection
  28. Why does SimpleDateFormat parse incorrect date?
  29. How to define a JUnit method rule in a test suite?
  30. JAVAFX : why wait cursor needs a new thread?

Leave a Comment