c++ vectors causing break in my game [closed]

by

Well I just had a quick look at that monstrosity, and I’m not going to look too far into it but right off the bat I see a problem.

I don’t know if this is related to this particular problem you are asking about, but this type of thing isn’t going to work the way you think:

for(long index=0; index < (long)RegularShots.vshots.size(); ++index) 
{ 
   RegularShots.vshots[index].y-=2;
   // Delete Shots
   if(RegularShots.vshots[index].y<-16)
   {
     RegularShots.vshots.erase(RegularShots.vshots.begin()+index);
   }
}

When you erase an item from the vector, the next item in the vector is moved down one, so every time you erase an item, you are skipping over the next item and not performing your test on it.

A quick fix here would be to do an index– after the erase call.

But based on what I’ve seen, I would seriously recommend that you do some reading on STL containers and iterators in particular. And then read some books on good coding style 😉

More Related Contents:

  1. What are the different calling conventions in C/C++ and what do each mean?
  2. CreateProcess from memory buffer
  3. C++ #include is not found
  4. Can I download the Visual C++ Command Line Compiler without Visual Studio?
  5. Why is std::vector::operator[] 5 to 10 times faster than std::vector::at()?
  6. How to erase & delete pointers to objects stored in a vector?
  7. How to create a process in C++ on Windows?
  8. Win32: Bring a window to top
  9. Self-inherited structure definition in C++
  10. WM_PAINT doesn't redraw figures
  11. How to Systematically use each item in a Vector [closed]
  12. Thou shalt not inherit from std::vector
  13. What’s the most efficient way to erase duplicates and sort a vector?
  14. Visual C++ equivalent of GCC’s __attribute__ ((__packed__))
  15. MSVC++ variadic macro expansion
  16. Visual Studio 2012 __cplusplus and C++ 11
  17. Sorting a vector in descending order
  18. Redirecting cout to a console in windows
  19. C++ compile time error: expected identifier before numeric constant
  20. How do I read from a version resource in Visual C++
  21. Create an Application without a Window
  22. c++ Vector, what happens whenever it expands/reallocate on stack?
  23. How to check if the program is run from a console?
  24. SendInput() not equal to pressing key manually on keyboard in C++?
  25. Variadic Template in VS 2012 (Visual C++ November 2012 CTP)
  26. Is there a way to get the string representation of HRESULT value using win API?
  27. Why are the return values of these doubles -1.#IND?
  28. Why does using push_back on a vector declared with size result in a vector of zeros?
  29. How to tell if a lib was compiled with /mt or /md?
  30. Visual Studio 2013: CL.exe exited with code -1073741515

Leave a Comment