Can i use nested loops with vectors in cpp?

by

One major issue is that your getNodes function returns a copy of a vector, not the original vector. Therefore your iterators you use in the loops are not iterating over the same vector.

Instead, the iterators you’re using in the nested loops are iterating over 4 different (but equivalent) vectors instead of the actual vector from the object in question.

There is nothing wrong in returning a copy of a vector in general. However when you do this, you have to make sure you call such a function if you really want a copy, and not the same vector. Using the getNodes function as you used it is not a valid usage in terms of what you are trying to accomplish.

The error is here:

inline vector<Node*> getNodes()  { return nodes; }

The fix:

inline vector<Node*>& getNodes() { return nodes; }

The latter ensures that a reference to the actual vector in question is returned, not a copy of the actual vector. You can add an additional function that returns the vector as a copy if you want to still have the functionality available.

More Related Contents:

  1. Please provide me the logic to print the result using PRINTF [closed]
  2. Adding some python flavor to C++ [closed]
  3. unsigned int vs. size_t
  4. Converting std::__cxx11::string to std::string
  5. Catching exception: divide by zero
  6. What’s the difference between __PRETTY_FUNCTION__, __FUNCTION__, __func__?
  7. Implementing comparison operators via ‘tuple’ and ‘tie’, a good idea?
  8. What is special about numbers starting with zero?
  9. C++ code file extension? What is the difference between .cc and .cpp [closed]
  10. Should I use an exception specifier in C++?
  11. How to copy/create derived class instance from a pointer to a polymorphic base class?
  12. Returning a pointer of a local variable C++
  13. How to use const_cast?
  14. Structure of a C++ Object in Memory Vs a Struct
  15. Trouble with inheritance of operator= in C++
  16. How to avoid precompiled headers
  17. Cast pointer to member function to normal pointer
  18. How to create the Cartesian product of a type list?
  19. How to create a DLL with SWIG from Visual Studio 2010
  20. initializing a C++ std::istringstream from an in memory buffer?
  21. Lambda expressions as class template parameters
  22. How to deal with bad_alloc in C++?
  23. Calling initializer_list constructor via make_unique/make_shared
  24. Why can’t I forward-declare a class in a namespace using double colons?
  25. Const correctness in C vs C++
  26. C++ #include semantics
  27. Convert ISO-8859-1 strings to UTF-8 in C/C++
  28. Random number generator – why seed every time
  29. Diamond Inheritance Lowest Base Class Constructor
  30. Calculate mean and standard deviation from a vector of samples in C++ using Boost

Leave a Comment