Cannot convert from an IEnumerable to an ICollection

by

ICollection<T> inherits from IEnumerable<T> so to assign the result of

IEnumerable<T> Get(string pk)

to an ICollection<T> there are two ways.

// 1. You know that the referenced object implements `ICollection<T>`,
//    so you can use a cast
ICollection<T> c = (ICollection<T>)Get("pk");

// 2. The returned object can be any `IEnumerable<T>`, so you need to 
//    enumerate it and put it into something implementing `ICollection<T>`. 
//    The easiest is to use `ToList()`:
ICollection<T> c = Get("pk").ToList();

The second options is more flexible, but has a much larger performance impact. Another option is to store the result as an IEnumerable<T> unless you need the extra functionality added by the ICollection<T> interface.

Additional Performance Comment

The loop you have

for (var index = 0; index < Items.Count(); index++)

works on an IEnumerable<T> but it is inefficient; each call to Count() requires a complete enumeration of all elements. Either use a collection and the Count property (without the parenthesis) or convert it into a foreach loop:

foreach(var item in Items)

More Related Contents:

  1. How to spawn a process and capture its STDOUT in .NET? [duplicate]
  2. Unable to read data from the transport connection : An existing connection was forcibly closed by the remote host
  3. What is a singleton in C#?
  4. System.MissingMethodException: Method not found?
  5. How do I check for nulls in an ‘==’ operator overload without infinite recursion?
  6. Print Pdf in C# [closed]
  7. Microsoft.Jet.OLEDB.4.0′ provider is not registered on the local machine
  8. C# Create New T()
  9. Is it considered acceptable to not call Dispose() on a TPL Task object?
  10. Getting the thread ID from a thread
  11. What does SynchronizationContext do?
  12. Is there a faster way to scan through a directory recursively in .NET?
  13. Getting a System.Type from type’s partial name
  14. Horizontal scroll for stackpanel doesn’t work
  15. Queuing in OneWay WCF Messages using Windows Service and SQL Server
  16. Creating simple c++.net wrapper. Step-by-step
  17. Enable SSL in Visual Studio
  18. internal vs public in C#
  19. ‘File.Copy’ does not overwrite a file
  20. Deserializing XML File with multiple element attributes – attributes are not deserializing
  21. Displaying tooltip on mouse hover of a text
  22. split a string on newlines in .NET
  23. Returning ‘IList’ vs ‘ICollection’ vs ‘Collection’
  24. Adding an attachment to email using C#
  25. In a .net Exception how to get a stacktrace with argument values
  26. Can JavaScriptSerializer exclude properties with null/default values?
  27. Built-in helper to parse User.Identity.Name into Domain\Username
  28. Are static variables thread-safe? C#
  29. Are there .NET Framework methods to parse an email (MIME)?
  30. How to create a form with a border, but no title bar? (like volume control on Windows 7)

Leave a Comment