Correct way to synchronize ArrayList in java

by

You’re synchronizing twice, which is pointless and possibly slows down the code: changes while iterating over the list need a synchronnization over the entire operation, which you are doing with synchronized (in_queue_list) Using Collections.synchronizedList() is superfluous in that case (it creates a wrapper that synchronizes individual operations).

However, since you are emptying the list completely, the iterated removal of the first element is the worst possible way to do it, sice for each element all following elements have to be copied, making this an O(n^2) operation – horribly slow for larger lists.

Instead, simply call clear() – no iteration needed.

Edit:
If you need the single-method synchronization of Collections.synchronizedList() later on, then this is the correct way:

List<Record> in_queue_list = Collections.synchronizedList(in_queue);
in_queue_list.clear(); // synchronized implicitly,

But in many cases, the single-method synchronization is insufficient (e.g. for all iteration, or when you get a value, do computations based on it, and replace it with the result). In that case, you have to use manual synchronization anyway, so Collections.synchronizedList() is just useless additional overhead.

More Related Contents:

  1. Concurrent threads adding to ArrayList at same time – what happens?
  2. Synchronization vs Lock
  3. How do I make my ArrayList Thread-Safe? Another approach to problem in Java?
  4. How do synchronized static methods work in Java and can I use it for loading Hibernate entities?
  5. Why do I need to synchronize a list returned by Collections.synchronizedList
  6. NumberFormatException not wrking java
  7. How to create a Java ArrayList in C
  8. What’s the difference between Thread start() and Runnable run()
  9. Convert list to array in Java [duplicate]
  10. Synchronizing on String objects in Java
  11. What’s a monitor in Java?
  12. Efficient way to divide a list into lists of n size
  13. What is the difference between a synchronized method and synchronized block in Java? [duplicate]
  14. Java threads and number of cores
  15. what is the sense of final ArrayList?
  16. Java volatile reference vs. AtomicReference
  17. Java synchronized block vs. Collections.synchronizedMap
  18. Simple way to compare 2 ArrayLists
  19. Initializing two threads with the same instance of a runnable
  20. Should you synchronize the run method? Why or why not?
  21. Why does Java not see the updated value from another thread?
  22. Hash Set and Array List performances
  23. What is adaptive spinning w.r.t lock acquisition?
  24. Check if an ArrayList contains every element from another ArrayList
  25. Adding to an ArrayList Java
  26. Can not deserialize instance of java.util.ArrayList out of VALUE_STRING
  27. Time Complexity for Java ArrayList
  28. How can I wrap a method so that I can kill its execution if it exceeds a specified timeout?
  29. How to change value of ArrayList element in java
  30. Add ArrayList to another ArrayList in java

Leave a Comment