Creating shared_ptr from raw pointer

by

You need to make sure you don’t initialize both shared_ptr objects with the same raw pointer, or it will be deleted twice. A better (but still bad) way to do it:

classA* raw_ptr = new classA;
shared_ptr<classA> my_ptr(raw_ptr);

// or shared_ptr<classA> my_ptr = raw_ptr;

// ...

shared_ptr<classA> other_ptr(my_ptr);
// or shared_ptr<classA> other_ptr = my_ptr;
// WRONG: shared_ptr<classA> other_ptr(raw_ptr);
// ALSO WRONG: shared_ptr<classA> other_ptr = raw_ptr;

WARNING: the above code shows bad practice! raw_ptr simply should not exist as a variable. If you directly initialize your smart pointers with the result of new, you reduce your risk of accidentally initializing other smart pointers incorrectly. What you should do is:

shared_ptr<classA> my_ptr(new classA);

shared_ptr<classA> other_ptr(my_ptr);

What’s nice is that the code is more concise as well.

EDIT

I should probably elaborate on how it would work with a map. If you had a raw pointer and two maps, you could do something similar to what I showed above.

unordered_map<string, shared_ptr<classA> > my_map;
unordered_map<string, shared_ptr<classA> > that_guys_map;

shared_ptr<classA> my_ptr(new classA);

my_map.insert(make_pair("oi", my_ptr));
that_guys_map.insert(make_pair("oi", my_ptr));
// or my_map["oi"].reset(my_ptr);
// or my_map["oi"] = my_ptr;
// so many choices!

More Related Contents:

  1. Why should I use a pointer rather than the object itself?
  2. How to add additional libraries to Visual Studio project?
  3. CMake error at CMakeLists.txt:30 (project): No CMAKE_C_COMPILER could be found
  4. Variable initialization in C++
  5. How to use the Qt’s PIMPL idiom?
  6. the procedure entry point __gxx_personality_v0 could not be located
  7. problem sorting using member function as comparator
  8. Constants and compiler optimization in C++
  9. C++: what regex library should I use? [closed]
  10. pinpointing “conditional jump or move depends on uninitialized value(s)” valgrind message
  11. Mismatch Detected for ‘RuntimeLibrary’
  12. Is adding to a “char *” pointer UB, when it doesn’t actually point to a char array?
  13. Allocating more memory than there exists using malloc
  14. std::unique_lock or std::lock_guard?
  15. delete[] an array of objects
  16. write and read string to binary file C++
  17. Which C++ signals/slots library should I choose? [closed]
  18. How do I get the application data path in Windows using C++?
  19. constexpr function parameters as template arguments
  20. Nullable values in C++
  21. Purpose of Trigraph sequences in C++?
  22. Which standard wording tells us that ref-to-const temporary lifetime extension only “works once”?
  23. When would anyone use a union? Is it a remnant from the C-only days?
  24. Rotate cv::Mat using cv::warpAffine offsets destination image
  25. Why does C++11 have `make_shared` but not `make_unique` [duplicate]
  26. What does ## in a #define mean?
  27. How to detect whether Windows is shutting down or restarting
  28. Is it legal for a C++ optimizer to reorder calls to clock()?
  29. How to create/read/write JSON files in Qt5
  30. How to test whether class B is derived from template family of classes

Leave a Comment