Does C++11 change the behavior of explicitly calling std::swap to ensure ADL-located swap’s are found, like boost::swap?

by

I would have had to vote against your proof-of-concept implementation had it been proposed. I fear it would break the following code, which I’m pretty sure I’ve seen in the wild at least once or twice over the past dozen years.

namespace oops
{

    struct foo
    {
        foo() : i(0) {}
        int i;

        void swap(foo& x) {std::swap(*this, x);}
    };

    void swap(foo& lhs, foo& rhs)
    {
        lhs.swap(rhs);
    }

}

Whether you think the above is good code or bad, it works as the author intends in C++98/03 and so the bar for silently breaking it is pretty high. Telling users that in C++11 they would no longer have to write using std::swap; isn’t a sufficiently high benefit to outweigh the disadvantage of silently turning the above code into infinite recursion.

Another way to get out of writing using std::swap; is to use std::iter_swap instead:

template <typename T>
void do_swap(T& lhs, T& rhs)
{
    std::iter_swap(&lhs, &rhs); // internally does what do_swap did above
}

More Related Contents:

  1. Has C++ standard changed with respect to the use of indeterminate values and undefined behavior in C++14?
  2. Optimizing away a “while(1);” in C++0x
  3. Is the size of std::array defined by standard
  4. Capturing a reference by reference in a C++11 lambda
  5. Is a moved-from vector always empty?
  6. c++ access static members using null pointer
  7. In C++11, does `i += ++i + 1` exhibit undefined behavior?
  8. Why is modifying a string through a retrieved pointer to its data not allowed?
  9. Get pointer to object from pointer to some member
  10. Are notes and examples in the core language specification of the C++ Standard non-normative?
  11. What does the void() in decltype(void()) mean exactly?
  12. Can the point-of-instantiation be delayed until the end of the translation unit?
  13. Can C++ code be valid in both C++03 and C++11 but do different things?
  14. What is the value category of the operands of C++ operators when unspecified?
  15. How can an incomplete type be used as a template parameter to vector here?
  16. Is the Empty Base Class Optimization now a mandatory optimization (at least for standard-layout classes)?
  17. Is left-shifting (
  18. What is the purpose of a declaration like int (x); or int (x) = 10;
  19. Is writing to &str[0] buffer (of a std:string) well-defined behaviour in C++11?
  20. Classes with both template and non-template conversion operators in the condition of switch statement
  21. Does C++11 allow dollar signs in identifiers?
  22. What expressions create xvalues?
  23. Why does the template-id in “A=0” not compile without space because of the greater-or-equal-than operator “>=”?
  24. Calling an explicit constructor with a braced-init list: ambiguous or not?
  25. Can we apply content not explicitly cited from the normative references to the C++ standard?
  26. Calling delete on NULL pointers – C++03 vs C++11
  27. std::tuple memory alignment
  28. Move semantics == custom swap function obsolete?
  29. What is use of the ref-qualifier `const &&`?
  30. Can using a lambda in header files violate the ODR?

Leave a Comment