ExecuteNonQuery: Connection property has not been initialized.

by

You need to assign the connection to the SqlCommand, you can use the constructor or the property:

cmd.InsertCommand = new SqlCommand("INSERT INTO Application VALUES (@EventLog, @TimeGenerated, @EventType, @SourceName, @ComputerName, @InstanceId, @Message) ");
cmd.InsertCommand.Connection = connection1;

I strongly recommend to use the using-statement for any type implementing IDisposable like SqlConnection, it’ll also close the connection:

using(var connection1 = new SqlConnection(@"Data Source=.\sqlexpress;Initial Catalog=syslog2;Integrated Security=True"))
using(var cmd = new SqlDataAdapter())
using(var insertCommand = new SqlCommand("INSERT INTO Application VALUES (@EventLog, @TimeGenerated, @EventType, @SourceName, @ComputerName, @InstanceId, @Message) "))
{
    insertCommand.Connection = connection1;
    cmd.InsertCommand = insertCommand;
    //.....
    connection1.Open();
    // .... you don't need to close the connection explicitely
}

Apart from that you don’t need to create a new connection and DataAdapter for every entry in the foreach, even if creating, opening and closing a connection does not mean that ADO.NET will create, open and close a physical connection but just looks into the connection-pool for an available connection. Nevertheless it’s an unnecessary overhead.

More Related Contents:

  1. SQL command INSERT is working but the data not appear in table
  2. Return value from SQL Server Insert command using c#
  3. How to execute a stored procedure within C# program
  4. How to get the connection String from a database
  5. How to directly execute SQL query in C#?
  6. How do I return multiple result sets with SqlCommand?
  7. Visual Studio: ContextSwitchDeadlock
  8. Query extremely slow in code but fast in SSMS
  9. How to connect to SQL server database from a Windows 10 UWP app
  10. ExecuteNonQuery for SELECT sql statement returning no rows
  11. SQLException : String or binary data would be truncated
  12. SSIS Task for inconsistent column count import?
  13. Entity-framework code is slow when using Include() many times
  14. Creating a SQL Server table from a C# datatable
  15. SQL: Update a row and returning a column value with 1 query
  16. Is there an Entity Framework 7 Database-First POCO Generator?
  17. Invalid column name sql error
  18. Retrieve image from database in asp.net
  19. Entity Framework | Sequence contains more than one matching element
  20. Keyword Not Supported: Metadata
  21. Why is EF generating SQL queries with unnecessary null-checks?
  22. Know when to retry or fail when calling SQL Server from C#?
  23. How to insert data into SQL Server
  24. SQL Server Database Change Listener C#
  25. “The operation is not valid for the state of the transaction” error and transaction scope
  26. How do I safely store database login and password in a C# application?
  27. Passing array to a SQL Server Stored Procedure
  28. Bulk Insert Sql Server millions of record
  29. Loading PictureBox Image From Database
  30. EF Core takes a lot of time, sometimes, to perform SELECT query

Leave a Comment