foreach vs someList.ForEach(){}

by

There is one important, and useful, distinction between the two.

Because .ForEach uses a for loop to iterate the collection, this is valid (edit: prior to .net 4.5 – the implementation changed and they both throw):

someList.ForEach(x => { if(x.RemoveMe) someList.Remove(x); });

whereas foreach uses an enumerator, so this is not valid:

foreach(var item in someList)
  if(item.RemoveMe) someList.Remove(item);

tl;dr: Do NOT copypaste this code into your application!

These examples aren’t best practice, they are just to demonstrate the differences between ForEach() and foreach.

Removing items from a list within a for loop can have side effects. The most common one is described in the comments to this question.

Generally, if you are looking to remove multiple items from a list, you would want to separate the determination of which items to remove from the actual removal. It doesn’t keep your code compact, but it guarantees that you do not miss any items.

More Related Contents:

  1. How to enumerate an enum
  2. In C#, why can’t a List object be stored in a List variable
  3. What is the best way to modify a list in a ‘foreach’ loop?
  4. Why isn’t there generic variance for classes in C# 4.0?
  5. Making a generic property
  6. Why cannot C# generics derive from one of the generic type parameters like they can in C++ templates? [duplicate]
  7. No type inference with generic extension method
  8. C# loop – break vs. continue
  9. Passing a single item as IEnumerable
  10. How do I make the return type of a method generic?
  11. Static Generic Class as Dictionary
  12. Get a generic method without using GetMethods
  13. explicitly cast generic type parameters to any interface
  14. Anonymous Types – Are there any distingushing characteristics?
  15. A reusable pattern to convert event into task
  16. Collection of generic types
  17. C# Generic Type Inference With Multiple Types
  18. How do I create a generic class from a string in C#? [duplicate]
  19. Parse string to enum type
  20. Declare a generic type instance dynamically [duplicate]
  21. T must be contravariantly valid
  22. Ambiguous call between two C# extension generic methods one where T:class and other where T:struct
  23. How do I tell if a type is a “simple” type? i.e. holds a single value
  24. How to define generic type limit to primitive types?
  25. Why doesn’t C# support implied generic types on class constructors?
  26. What’s Wrong with an ArrayList?
  27. Implementing arithmetic in generics?
  28. The component does not have a resource identified by the uri
  29. C# generic methods, type parameters in new() constructor constraint
  30. generic NOT constraint where T : !IEnumerable

Leave a Comment