Fragment onCreateView and onActivityCreated called twice

by

I was scratching my head about this for a while too, and since Dave’s explanation is a little hard to understand I’ll post my (apparently working) code:

private class TabListener<T extends Fragment> implements ActionBar.TabListener {
    private Fragment mFragment;
    private Activity mActivity;
    private final String mTag;
    private final Class<T> mClass;

    public TabListener(Activity activity, String tag, Class<T> clz) {
        mActivity = activity;
        mTag = tag;
        mClass = clz;
        mFragment=mActivity.getFragmentManager().findFragmentByTag(mTag);
    }

    public void onTabSelected(Tab tab, FragmentTransaction ft) {
        if (mFragment == null) {
            mFragment = Fragment.instantiate(mActivity, mClass.getName());
            ft.replace(android.R.id.content, mFragment, mTag);
        } else {
            if (mFragment.isDetached()) {
                ft.attach(mFragment);
            }
        }
    }

    public void onTabUnselected(Tab tab, FragmentTransaction ft) {
        if (mFragment != null) {
            ft.detach(mFragment);
        }
    }

    public void onTabReselected(Tab tab, FragmentTransaction ft) {
    }
}

As you can see it’s pretty much like the Android sample, apart from not detaching in the constructor, and using replace instead of add.

After much headscratching and trial-and-error I found that finding the fragment in the constructor seems to make the double onCreateView problem magically go away (I assume it just ends up being null for onTabSelected when called through the ActionBar.setSelectedNavigationItem() path when saving/restoring state).

More Related Contents:

  1. getView returning null when fragment has been created from an activity
  2. How to implement onBackPressed() in Fragments?
  3. How to determine when Fragment becomes visible in ViewPager
  4. Do fragments really need an empty constructor?
  5. IllegalStateException: Can not perform this action after onSaveInstanceState with ViewPager
  6. How to transfer some data to another Fragment?
  7. Dilemma: when to use Fragments vs Activities:
  8. Why fragments, and when to use fragments instead of activities?
  9. Programmatically go back to the previous fragment in the backstack
  10. Refresh Fragment at reload
  11. Android Fragment onAttach() deprecated
  12. How to implement RecyclerView with CardView rows in a Fragment with TabLayout
  13. Android Fragments. Retaining an AsyncTask during screen rotation or configuration change
  14. Hide/Show bottomNavigationView on Scroll
  15. Difference between android.app.Fragment and android.support.v4.app.Fragment
  16. PreferenceFragmentCompat requires preferenceTheme to be set
  17. android.content.Context.getPackageName()’ on a null object reference
  18. onClickListener does not work in fragment
  19. How to wrap the height of a ViewPager to the height of its current Fragment?
  20. How to use Holo.Light theme, and fall back to ‘Light’ on pre-honeycomb devices?
  21. Detect ViewPager tab change inside Fragment
  22. TYPE_SYSTEM_OVERLAY in ICS
  23. findFragmentById always returns null
  24. How to replace the activity’s fragment from the fragment itself?
  25. Communication between Fragments in ViewPager
  26. Use external application fragment/activity inside application
  27. How to open fragment page, when pressed a notification in android
  28. OnCreateView called multiple times / Working with ActionBar and Fragments
  29. Android Two Fragments in Same Activity
  30. Pop up window to display some stuff in a fragment

Leave a Comment