getting control reaches end of non-void function from hcf function

by

This function has to return some int — that’s the compiler error here.

However there are many other issues.

  • the gcd of two coprime numbers is 1, by definiton. If a and b are coprime then the return in the for loop is never encountered.
  • the return in the for loop is never encountered for negative a or b either, as tkausl points out
  • even if the loop runs, there’s a bug in it. For any a>=0 and b>=0 you’re going to return 1 when i = 1, because a % 1 == 0 && b % 1 == 0 is always true.
int hcf (int a, int b) {
            int gcd;
    
            for (int i = 0; i <= a && i <= b; i++) {
                   if (a % i == 0 && b % i == 0) { /* <<< wrong <<< */
                   gcd = i;
                   return gcd;
                  }
            }

            // a and b have no common divisor
            return 1;
}

More Related Contents:

  1. which is faster assigning a number to the variable or changing the value of that variable either by adding or subtracting some number?
  2. Storing value of unsigned int variable in char array in C [closed]
  3. C program goes into infinite loop with scanf [duplicate]
  4. About C function
  5. How do I store a 16 byte binary value that can be represented as a 32 hexadecimal characters in an unsigned char* variable in C
  6. self referential struct definition?
  7. Getting “conflicting types for function” in C, why?
  8. func() vs func(void) in C99
  9. Are stack variables aligned by the GCC __attribute__((aligned(x)))?
  10. C99 inline function in .c file
  11. Need of Pointer to pointer
  12. Bitfield manipulation in C
  13. What’s the use of suffix `f` on float value
  14. What happens when a variable goes out of scope?
  15. Wrap around explanation for signed and unsigned variables in C?
  16. Where to find stdio.h functions implementations?
  17. Getting Segmentation Fault
  18. Delete a Line from a file in C Language
  19. Why are global variables bad, in a single threaded, non-os, embedded application
  20. Convert double/float to string
  21. Find malloc() array length in C? [duplicate]
  22. Is there a meaningful distinction between freestanding and hosted implementations?
  23. Deep Analysis of Const Qualifier in C
  24. Determine if a C string is a valid int in C
  25. Store data in array from input [duplicate]
  26. What is the use of typedef?
  27. Dereference void pointer
  28. Why can’t a modifiable lvalue have an array type?
  29. functions returning char pointer
  30. How to implement Bitcount using only Bitwise operators?

Leave a Comment