How can I capture the value of an outer variable inside a lambda expression?

by

This has more to do with lambdas than threading. A lambda captures the reference to a variable, not the variable’s value. This means that when you try to use i in your code, its value will be whatever was stored in i last.

To avoid this, you should copy the variable’s value to a local variable when the lambda starts. The problem is, starting a task has overhead and the first copy may be executed only after the loop finishes. The following code will also fail

for (var i = 0; i < 50; ++i) {
    Task.Factory.StartNew(() => {
        var i1=i;
        Debug.Print("Error: " + i1.ToString());
    });
}

As James Manning noted, you can add a variable local to the loop and copy the loop variable there. This way you are creating 50 different variables to hold the value of the loop variable, but at least you get the expected result. The problem is, you do get a lot of additional allocations. 

for (var i = 0; i < 50; ++i) {
    var i1=i;
    Task.Factory.StartNew(() => {
        Debug.Print("Error: " + i1.ToString());
    });
}

The best solution is to pass the loop parameter as a state parameter:

for (var i = 0; i < 50; ++i) {
    Task.Factory.StartNew(o => {
        var i1=(int)o;
        Debug.Print("Error: " + i1.ToString());
    }, i);
}

Using a state parameter results in fewer allocations. Looking at the decompiled code:

  • the second snippet will create 50 closures and 50 delegates
  • the third snippet will create 50 boxed ints but only a single delegate

More Related Contents:

  1. How to limit the amount of concurrent async I/O operations?
  2. WaitAll vs WhenAll
  3. Catch an exception thrown by an async void method
  4. Running multiple async tasks and waiting for them all to complete
  5. Run two async tasks in parallel and collect results in .NET 4.5
  6. Calling async method synchronously
  7. Why does this async action hang when I try and access the Result property of my Task?
  8. Best way in .NET to manage queue of tasks on a separate (single) thread
  9. Task sequencing and re-entracy
  10. Enforce an async method to be called once
  11. What’s the difference between returning void and returning a Task?
  12. Best way to convert callback-based async method to awaitable task
  13. Executing tasks in parallel
  14. Calling async methods from non-async code
  15. Use Task.Run() in synchronous method to avoid deadlock waiting on async method?
  16. Task.Factory.StartNew with async lambda and Task.WaitAll
  17. A pattern for self-cancelling and restarting task
  18. What is the correct way to cancel an async operation that doesn’t accept a CancellationToken?
  19. ForEachAsync with Result
  20. Converting async/await to Task.ContinueWith
  21. How to throttle multiple asynchronous tasks?
  22. Synchronous implementation of interface that returns Task
  23. Is it possible to get successful results from a Task.WhenAll when one of the tasks fails? [duplicate]
  24. Task.Run with Parameter(s)?
  25. HttpClient.SendAsync using the thread-pool instead of async IO?
  26. How to implement Task.WhenAny() with a predicate
  27. Calling TaskCompletionSource.SetResult in a non blocking manner
  28. Why should I prefer single ‘await Task.WhenAll’ over multiple awaits?
  29. Why do some C# lambda expressions compile to static methods?
  30. For a TPL Dataflow: How do I get my hands on all the output produced by a TransformBlock while blocking until all inputs have been processed?

Leave a Comment