To some extent, random number generators are horses for courses. The Random class implements an LCG with reasonably chosen parameters. But it still exhibits the following features:
- fairly short period (2^48)
- bits are not equally random (see my article on randomness of bit positions)
- will only generate a small fraction of combinations of values (the famous problem of “falling in the planes“)
If these things don’t matter to you, then Random has the redeeming feature of being provided as part of the JDK. It’s good enough for things like casual games (but not ones where money is involved). There are no weak seeds as such.
Another alternative which is the XORShift generator, which can be implemented in Java as follows:
public long randomLong() {
x ^= (x << 21);
x ^= (x >>> 35);
x ^= (x << 4);
return x;
}
For some very cheap operations, this has a period of 2^64-1 (zero is not permitted), and is simple enough to be inlined when you’re generating values repeatedly. Various shift values are possible: see George Marsaglia’s paper on XORShift Generators for more details. You can consider bits in the numbers generated as being equally random. One main weakness is that occasionally it will get into a “rut” where not many bits are set in the number, and then it takes a few generations to get out of this rut.
Other possibilities are:
- combine different generators (e.g. feed the output from an XORShift generator into an LCG, then add the result to the output of an XORShift generator with different parameters): this generally allows the weaknesses of the different methods to be “smoothed out”, and can give a longer period if the periods of the combined generators are carefully chosen
- add a “lag” (to give a longer period): essentially, where a generator would normally transform the last number generated, store a “history buffer” and transform, say, the (n-1023)th.
I would say avoid generators that use a stupid amount of memory to give you a period longer than you really need (some have a period greater than the number of atoms in the universe– you really don’t usually need that). And note that “long period” doesn’t necessarily mean “high quality generator” (though 2^48 is still a little bit low!).