How to fix jslint error ‘Don’t make functions within a loop.’?

by

Douglas Crockford has a new idiomatic way of achieving the above – his old technique was to use an inner function to bind the variables, but the new technique uses a function maker. See slide 74 in the slides to his “Function the Ultimate” talk. [This slideshare no longer exists]

For the lazy, here is the code:

function make_handler(div_id) {
    return function () {
        alert(div_id);
    };
}
for (i ...) {
    div_id = divs[i].id;
    divs[i].onclick = make_handler(div_id);
}

More Related Contents:

  1. What does "use strict" do in JavaScript, and what is the reasoning behind it?
  2. Why avoid increment (“++”) and decrement (“–“) operators in JavaScript?
  3. What is the difference between `new Object()` and object literal notation?
  4. How to initialize an array’s length in JavaScript?
  5. Immediate function invocation syntax
  6. (…()) vs. (…)() in javascript closures [duplicate]
  7. JavaScript function order: why does it matter?
  8. How to split a long regular expression into multiple lines in JavaScript?
  9. What’s wrong with var x = new Array();
  10. What is array literal notation in javascript and when should you use it?
  11. JSLint is suddenly reporting: Use the function form of “use strict”
  12. Should I use JSLint or JSHint JavaScript validation? [closed]
  13. Why should you not use Number as a constructor? [duplicate]
  14. JSlint error ‘Don’t make functions within a loop.’ leads to question about Javascript itself
  15. JSlint: unexpected ‘for’ [duplicate]
  16. JSLint error: Move all ‘var’ declarations to the top of the function
  17. Don’t make functions within a loop [duplicate]
  18. JSLint “insecure ^” in regular expression
  19. JSLint Expected ‘===’ and instead saw ‘==’
  20. Why is JSHINT complaining that this is a strict violation?
  21. JSLint Error: Unexpected ‘this’
  22. What does the JSLint error ‘body of a for in should be wrapped in an if statement’ mean?
  23. JSLint: was used before it was defined
  24. JSLint: Using a function before it’s defined error
  25. JSLint: control comments (selective ignore)
  26. how do an infinite loop in javascript
  27. When should I use a return statement in ES6 arrow functions
  28. Evaluating a string as a mathematical expression in JavaScript
  29. How to enable cors nodejs with express?
  30. JavaScript, Node.js: is Array.forEach asynchronous?

Leave a Comment