How to remove from a map while iterating it?

by

The standard associative-container erase idiom:

for (auto it = m.cbegin(); it != m.cend() /* not hoisted */; /* no increment */)
{
  if (must_delete)
  {
    m.erase(it++);    // or "it = m.erase(it)" since C++11
  }
  else
  {
    ++it;
  }
}

Note that we really want an ordinary for loop here, since we are modifying the container itself. The range-based loop should be strictly reserved for situations where we only care about the elements. The syntax for the RBFL makes this clear by not even exposing the container inside the loop body.

Edit. Pre-C++11, you could not erase const-iterators. There you would have to say:

for (std::map<K,V>::iterator it = m.begin(); it != m.end(); ) { /* ... */ }

Erasing an element from a container is not at odds with constness of the element. By analogy, it has always been perfectly legitimate to delete p where p is a pointer-to-constant. Constness does not constrain lifetime; const values in C++ can still stop existing.

More Related Contents:

  1. Choosing between std::map and std::unordered_map [duplicate]
  2. Dots in printf in C++
  3. What does the namespace std add? (C++) [closed]
  4. Passing object by reference to std::thread in C++11
  5. C++11 make_pair with specified template parameters doesn’t compile
  6. Is a moved-from vector always empty?
  7. Should we pass a shared_ptr by reference or by value?
  8. declare template friend function of template class
  9. How do I use unique_ptr for pimpl?
  10. Significance of parentheses in decltype((c))?
  11. Why is modifying a string through a retrieved pointer to its data not allowed?
  12. Mesh class called with default constructor not working OpenGL C++
  13. std::put_time implementation status in GCC?
  14. Are notes and examples in the core language specification of the C++ Standard non-normative?
  15. What is std::decay and when it should be used?
  16. Where can I learn more about C++0x? [closed]
  17. What is the default hash function used in C++ std::unordered_map?
  18. Comparing std::functions for equality?
  19. Do these members have unspecified ordering?
  20. scanf on an istream object
  21. Check traits for all variadic template arguments
  22. Convert between string, u16string & u32string
  23. Is there any case where a return of a RValue Reference (&&) is useful?
  24. Dynamic aligned memory allocation in C++11
  25. Has the new C++11 member initialization feature at declaration made initialization lists obsolete?
  26. What is different between join() and detach() for multi threading in C++?
  27. Advantage of using trailing return type in C++11 functions
  28. std::unique_ptr with derived class
  29. Dependent name resolution & namespace std / Standard Library
  30. Why do we use std::function in C++ rather than the original C function pointer? [duplicate]

Leave a Comment