Is it bad to explicitly compare against boolean constants e.g. if (b == false) in Java?

by

It’s not necessarily bad, it’s just superfluous. Also, the actual variable name weights a lot. I would prefer for example if (userIsAllowedToLogin) over if (b) or even worse if (flag).

As to the performance concern, the compiler optimizes it away at any way.

As to the authoritative sources, I can’t find something explicitly in the Java Code Conventions as originally written by Sun, but at least Checkstyle has a SimplifyBooleanExpression module which would warn about that.

More Related Contents:

  1. Difference boolean[] b = {false} vs. boolean b = false? [closed]
  2. boolean doesn't set to true in Java
  3. java array of booleans all set to the same value [closed]
  4. String index out of range in jva
  5. What is the difference between & and && in Java?
  6. Is it ok if I omit curly braces in Java? [closed]
  7. Java: Ternary with no return. (For method calling)
  8. Volatile boolean vs AtomicBoolean
  9. Booleans, conditional operators and autoboxing
  10. for loop optimization
  11. What code folding plugins work on Eclipse 3.6?
  12. Convert boolean to int in Java
  13. Stand-alone Java code formatter/beautifier/pretty printer? [closed]
  14. What is the most elegant way to check if all values in a boolean array are true?
  15. Java Conventions: use getters/setters WITHIN the class?
  16. Conveniently map between enum and int / String
  17. Any reason to clean up unused imports in Java, other than reducing clutter?
  18. Is it good practice to use ordinal of enum?
  19. Java modifiers syntax and format
  20. Java: boolean in println (boolean ? “print true”:”print false”) [duplicate]
  21. Modifier Keyword order in Java
  22. Default value of ‘boolean’ and ‘Boolean’ in Java
  23. For a boolean field, what is the naming convention for its getter/setter?
  24. Check if at least two out of three booleans are true
  25. Where should I put @Transactional annotation: at an interface definition or at an implementing class?
  26. Oracle Java code conventions
  27. Get rid of ugly if statements
  28. Is concatenating with an empty string to do a string conversion really that bad?
  29. Boolean checking in the ‘if’ condition
  30. Get random boolean in Java

Leave a Comment