Is it OK to use a string as a lock object?

by

Locking on strings is discouraged, the main reason is that (because of string-interning) some other code could lock on the same string instance without you knowing this. Creating a potential for deadlock situations.

Now this is probably a far fetched scenario in most concrete situations. It’s more a general rule for libraries.

But on the other hand, what is the perceived benefit of strings?

So, point for point:

Are there any problems with this approach?

Yes, but mostly theoretical.

Is it OK to lock on a string object in this way, and are there any thread safety issues in using the HashSet?

The HashSet<> is not involved in the thread-safety as long as the threads only read concurrently.

Is it better to, for example, create a Dictionary that creates a new lock object for each string instance?

Yes. Just to be on the safe side. In a large system the main aim for avoiding deadlock is to keep the lock-objects as local and private as possible. Only a limited amount of code should be able to access them.

More Related Contents:

  1. Re-entrant locks in C#
  2. Does a locked object stay locked if an exception occurs inside it?
  3. How expensive is the lock statement?
  4. Monitor vs lock
  5. Do I need to lock or mark as volatile when accessing a simple boolean flag in C#?
  6. lowering priority of Task.Factory.StartNew thread
  7. Creating threads – Task.Factory.StartNew vs new Thread()
  8. When is ReaderWriterLockSlim better than a simple lock?
  9. When exactly does .NET Monitor go to kernel-mode?
  10. Creating a blocking Queue in .NET?
  11. What’s the difference between Invoke() and BeginInvoke()
  12. Question about terminating a thread cleanly in .NET
  13. What operations are atomic in C#?
  14. Accessing UI (Main) Thread safely in WPF
  15. ‘using’ statement vs ‘try finally’
  16. Thread.Sleep for less than 1 millisecond
  17. Is Task.Factory.StartNew() guaranteed to use another thread than the calling thread?
  18. Returning a value from thread?
  19. Async process start and wait for it to finish
  20. Regarding local variable passing in Thread
  21. Does lock() guarantee acquired in order requested?
  22. The calling thread cannot access this object because a different thread owns it.WPF [duplicate]
  23. Lock-free multi-threading is for real threading experts
  24. How to achieve remove_if functionality in .NET ConcurrentDictionary
  25. Why does the lock object have to be static?
  26. Async thread body loop, It just works, but how?
  27. Why is it a bad practice to lock the object we are going to change?
  28. Starting a new thread in a foreach loop
  29. Multithreaded NamePipeServer in C#
  30. Half – fences and full fences? [duplicate]

Leave a Comment