Is it safe to use a boolean flag to stop a thread from running in C#

by

You better mark it volatile though:

The volatile keyword indicates that a
field might be modified by multiple
concurrently executing threads. Fields
that are declared volatile are not
subject to compiler optimizations that
assume access by a single thread. This
ensures that the most up-to-date value
is present in the field at all times.

But I would change your loop:

    startSignal.WaitOne();
    while(running)
    {
        //... some code
        startSignal.WaitOne();
    }

As it is in your post the ‘some code’ might execute when the thread is stopped (ie. when Stop is called) which is unexpected and may be even incorrect.

More Related Contents:

  1. Create Dynamic Threads in c# [closed]
  2. Automating the InvokeRequired code pattern
  3. Concurrent HashSet in .NET Framework?
  4. Are C# arrays thread safe?
  5. How to create a task (TPL) running a STA thread?
  6. Why we need Thread.MemoryBarrier()?
  7. Why do I need a memory barrier?
  8. Thread safety of a Dictionary with multiple concurrent readers and no writers
  9. Are IEnumerable Linq methods thread-safe?
  10. Do I need to lock or mark as volatile when accessing a simple boolean flag in C#?
  11. thread with multiple parameters
  12. Event handlers not thread safe? [duplicate]
  13. Is this use of Parallel.ForEach() thread safe?
  14. How to correctly read an Interlocked.Increment’ed int field?
  15. Thread Safe Properties in C#
  16. ConcurrentDictionary Pitfall – Are delegates factories from GetOrAdd and AddOrUpdate synchronized?
  17. Thread safety on readonly static field initialisation
  18. Is Stopwatch.ElapsedTicks threadsafe?
  19. C# Thread safe fast(est) counter
  20. C# and thread-safety of a bool
  21. Is it possible to observe a partially-constructed object from another thread?
  22. SqlConnection Thread-Safe?
  23. Writing to file in a thread safe manner
  24. Why is Thread.Sleep so harmful
  25. Is malloc thread-safe?
  26. C#: Waiting for all threads to complete
  27. C# thread safety with get/set
  28. Wait for a while without blocking main thread
  29. How to access a WinForms control from another thread i.e. synchronize with the GUI thread?
  30. Memory usage in C#

Leave a Comment