Is Josh Smith’s implementation of the RelayCommand flawed?

by

I’ve found the answer in Josh’s comment on his “Understanding Routed Commands” article:

[…] you have to use the WeakEvent pattern in your CanExecuteChanged
event. This is because visual elements will hook that event, and since
the command object might never be garbage collected until the app
shuts down, there is a very real potential for a memory leak. […]

The argument seems to be that CanExecuteChanged implementors must only hold weakly to the registered handlers, since WPF Visuals are to stupid to unhook themselves. This is most easily implemented by delegating to the CommandManager, who already does this. Presumably for the same reason.

More Related Contents:

  1. What is the actual task of CanExecuteChanged and CommandManager.RequerySuggested?
  2. INotifyPropertyChanged vs. DependencyProperty in ViewModel
  3. Pushing read-only GUI properties back into ViewModel
  4. Why RelayCommand
  5. Firing a double click event from a WPF ListView item using MVVM
  6. Open File Dialog MVVM
  7. What is a ViewModelLocator and what are its pros/cons compared to DataTemplates?
  8. Passing parameters between viewmodels
  9. Why MVVM and what are it’s core benefits? [duplicate]
  10. Keyboard events in a WPF MVVM application?
  11. How to open a new window using MVVM Light Toolkit
  12. Grouping items in a ComboBox
  13. KeyBinding in UserControl doesn’t work when TextBox has the focus
  14. WPF Grid as ItemsPanel for a list dynamically bound to an ItemsControl
  15. How have you successfully implemented MessageBox.Show() functionality in MVVM?
  16. How can I Have a WPF EventTrigger on a View trigger when the underlying Viewmodel dictates it should?
  17. How to make all controls resize accordingly proportionally when window is maximized?
  18. Weird problem where Button does not get re-enabled unless the mouse is clicked
  19. Prism Custom Confirmation Interaction
  20. How can I sort a ListBox using only XAML and no code-behind?
  21. CommandManager.InvalidateRequerySuggested() isn’t fast enough. What can I do?
  22. Binding a WPF DataGridComboBoxColumn with MVVM
  23. How to cancel an edit to an object using MVVM?
  24. MVVM and the TextBox’s SelectedText property
  25. InputBindings work only when focused
  26. Is MVVM pattern broken?
  27. WPF Context menu on left click
  28. Keybinding a RelayCommand
  29. MVVM binding command to contextmenu item
  30. typesafe NotifyPropertyChanged using linq expressions

Leave a Comment