Is returning a pointer to a static local variable safe?

by

First example: Somewhat safe

char* const GetString()
{
  static char sTest[5];
  strcpy(sTest, "Test");
  return sTest;
}

Although not recommended, this is safe, the scope of a static variable remains alive even when the scope of the function ends. This function is not very thread-safe at all. A better function would get you to pass a char* buffer and a maxsize for the GetString() function to fill.

In particular, this function is not considered a reentrant function because reentrant functions must not, amongst other things, return the address to static (global) non-constant data. See reentrant functions.

Second example: Completely unsafe

char* const GetString()
{
  return "Test";
}

This would be safe if you did a const char *.
What you gave is not safe. The reason is because string literals can be stored in a read only memory segment and allowing them to be modified will cause undefined results.

char* const (const pointer) means that you can’t change the address the pointer is pointing to. const char * (pointer to const) means that you can’t change the elements that this pointer is pointing to.

Conclusion:

You should consider either:

1) If you have access to the code then modify the GetString to take a parameter of a char* buffer to fill and a maxsize to use.

2) If you do not have access to the code, but you must call it, wrap this method in another function which is protected by a mutex. The new method is as described in 1.

More Related Contents:

  1. C | Static array: why does writing out-of-bounds not result in exception? [duplicate]
  2. What does “static” mean in C?
  3. What is the purpose of static keyword in array parameter of function like “char s[static 10]”?
  4. What is a “static” function in C?
  5. How to deal with symbol collisions between statically linked libraries?
  6. Static variable inside of a function in C
  7. Variably modified array at file scope
  8. The initialization of static variables in C
  9. Can I mix static and shared-object libraries when linking?
  10. What’s the difference between static inline, extern inline and a normal inline function?
  11. Creating static Mac OS X C build
  12. When to use static keyword before global variables?
  13. Global variables in C are static or not?
  14. Static vs global
  15. variably modified array at file scope in C
  16. Why can’t the size of a static array be made variable?
  17. How are static variables with the same name in different functions identified by the System?
  18. static function in C
  19. What is the difference between static const and const?
  20. What does static mean in ANSI-C [duplicate]
  21. When to put static function definitions in header files in C?
  22. Is it possible to declare multiple static variables with same name in a single C file?
  23. Why won’t extern link to a static variable?
  24. How to pass arguments
  25. C – Trouble calling a function
  26. Threadsafe vs re-entrant
  27. What is this strange function definition syntax in C? [duplicate]
  28. Read input.txt file and also output.bmp file from terminal (C-programming)
  29. how to quit the blocking of xlib’s XNextEvent
  30. What is the meaning of a dot (.) after an integer in c?

Leave a Comment