Is the += operator thread-safe in Python?

by

No, this code is absolutely, demonstrably not threadsafe.

import threading

i = 0

def test():
    global i
    for x in range(100000):
        i += 1

threads = [threading.Thread(target=test) for t in range(10)]
for t in threads:
    t.start()

for t in threads:
    t.join()

assert i == 1000000, i

fails consistently.

i += 1 resolves to four opcodes: load i, load 1, add the two, and store it back to i. The Python interpreter switches active threads (by releasing the GIL from one thread so another thread can have it) every 100 opcodes. (Both of these are implementation details.) The race condition occurs when the 100-opcode preemption happens between loading and storing, allowing another thread to start incrementing the counter. When it gets back to the suspended thread, it continues with the old value of “i” and undoes the increments run by other threads in the meantime.

Making it threadsafe is straightforward; add a lock:

#!/usr/bin/python
import threading
i = 0
i_lock = threading.Lock()

def test():
    global i
    i_lock.acquire()
    try:
        for x in range(100000):
            i += 1
    finally:
        i_lock.release()

threads = [threading.Thread(target=test) for t in range(10)]
for t in threads:
    t.start()

for t in threads:
    t.join()

assert i == 1000000, i

More Related Contents:

  1. What happens when start value < end value with range() cmd in Python?
  2. Are global variables thread-safe in Flask? How do I share data between requests?
  3. Behaviour of increment and decrement operators in Python
  4. Redirecting stdout and stderr to a PyQt4 QTextEdit from a secondary thread
  5. Thread Safety in Python’s dictionary
  6. Python integer incrementing with ++ [duplicate]
  7. How to make built-in containers (sets, dicts, lists) thread safe?
  8. Is the Session object from Python’s Requests library thread safe?
  9. Simplest way for PyQT Threading
  10. How to increment variable names/Is this a bad idea [duplicate]
  11. Are urllib2 and httplib thread safe?
  12. Queue.Queue vs. collections.deque
  13. Are Python built-in containers thread-safe?
  14. Are Generators Threadsafe?
  15. How to share a variable between 2 threads
  16. Python 2.7: Print thread safe
  17. python dictionary is thread safe?
  18. How do I resize an image using PIL and maintain its aspect ratio?
  19. Is there any pythonic way to combine two dicts (adding values for keys that appear in both)?
  20. How to kill a while loop with a keystroke?
  21. Find all combinations of a list of numbers with a given sum
  22. How to find most common elements of a list? [duplicate]
  23. The zip() function in Python 3 [duplicate]
  24. Find substring in string but only if whole words?
  25. Why doesn’t multiple on_message events work?
  26. How does one do the equivalent of “import * from module” with Python’s __import__ function?
  27. Interacting with bash from python
  28. Indexing a list with an unique index
  29. How do I annotate types in a for-loop?
  30. Error in RK4 algorithm in Python

Leave a Comment