is using an an `async` lambda with `Task.Run()` redundant?

by

Normally, the intended usage for Task.Run is to execute CPU-bound code on a non-UI thread. As such, it would be quite rare for it to be used with an async delegate, but it is possible (e.g., for code that has both asynchronous and CPU-bound portions).

However, that’s the intended usage. I think in your example:

var task = Task.Run(async () => { await Foo.StartAsync(); });
task.Wait();

It’s far more likely that the original author is attempting to synchronously block on asynchronous code, and is (ab)using Task.Run to avoid deadlocks common in that situation (as I describe on my blog).

In essence, it looks like the “thread pool hack” that I describe in my article on brownfield asynchronous code.

The best solution is to not use Task.Run or Wait:

await Foo.StartAsync();

This will cause async to grow through your code base, which is the best approach, but may cause an unacceptable amount of work for your developers right now. This is presumably why your predecessor used Task.Run(..).Wait().

More Related Contents:

  1. Benefits of using async and await keywords
  2. Why use async and return await, when you can return Task directly?
  3. Should I worry about “This async method lacks ‘await’ operators and will run synchronously” warning
  4. caching the result from a [n async] factory method iff it doesn’t throw
  5. Can’t specify the ‘async’ modifier on the ‘Main’ method of a console app
  6. HttpClient.GetAsync(…) never returns when using await/async
  7. Running multiple async tasks and waiting for them all to complete
  8. How to limit the Maximum number of parallel tasks in c#
  9. Task sequencing and re-entracy
  10. Asynchronous Task.WhenAll with timeout
  11. .NET Asynchronous stream read/write
  12. Waiting for async/await inside a task
  13. How does Task become an int?
  14. Do asynchronous operations in ASP.NET MVC use a thread from ThreadPool on .NET 4
  15. Why does the async keyword exist
  16. Executing tasks in parallel
  17. Proper way to start and fire-and-forget asynchronous calls?
  18. Use Task.Run() in synchronous method to avoid deadlock waiting on async method?
  19. What happens while waiting on a Task’s Result?
  20. Asynchronous iterator Task
  21. A pattern for self-cancelling and restarting task
  22. Async always WaitingForActivation
  23. A pattern to pause/resume an async task?
  24. Converting async/await to Task.ContinueWith
  25. How to Async Files.ReadAllLines and await for results?
  26. Is it possible to get successful results from a Task.WhenAll when one of the tasks fails? [duplicate]
  27. Can I cancel StreamReader.ReadLineAsync with a CancellationToken?
  28. Task chaining (wait for the previous task to completed)
  29. Sessions in Asynchronous design
  30. Timeout pattern on task-based asynchronous method in C#

Leave a Comment