Issue with cin when spaces are inputted, using string class

by

Here’s what’s happening with the input buffer when you run your program:

std::cin >> name;

You’re waiting for input. When you enter “Ryan Cleary”, and press enter, the input buffer contains:

Ryan Cleary\n

Now your cin reads input as normal, stopping at whitespace, leaving your buffer like this:

 Cleary\n

Note the beginning space, as it stops after reading Ryan. Your first variable now contains Ryan. If, however, you want the full name, use std::getline. It will read until a newline, not just whitespace. Anyway, continuing on:

std::cin >> age;

Now you’re getting another input. There’s already something there, though. It skips the whitespace until it can start reading, leaving the buffer with just: 

\n

Your second variable gets the text Cleary. Note the newline still in the buffer, which brings me to the second part. Replacing system ("pause"); in a way that always works is tricky. Your best bet is usually to live with a less-than-perfect solution, or as I like to do, one that isn’t guaranteed to do exactly what it says:

std::cin.get(); //this consumes the left over newline and exits without waiting

Okay, so cin.get() didn’t work. How about this:

std::cin.get(); //consume left over newline
std::cin.get(); //wait

That works perfectly, but what if you copy-paste it somewhere where the newline isn’t left over? You’ll have to hit enter twice!

The solution is to clear the newline (and anything else) out, and then wait. This is the purpose of cin.sync(). However, as seen in the notes section, it is not guaranteed to clear the buffer out like it says, so if your compiler chooses not to, it can’t be used. For me, however, it does exactly that, leaving a solution of:

std::cin.sync(); //clear buffer
std::cin.get(); //wait

The main bad thing about system("pause"); is that you have no idea what program it will run on someone else’s computer. They could’ve changed pause.exe or put one that’s found first, and you have no way of knowing. This could potentially ruin their computer due to it being possibly any program.

More Related Contents:

  1. Insertion sort stops working after million input
  2. Read whole ASCII file into C++ std::string [duplicate]
  3. How do I read an entire file into a std::string in C++?
  4. How can I convert a std::string to int?
  5. std::string formatting like sprintf
  6. Legality of COW std::string implementation in C++11
  7. How can I use cout
  8. C++ convert string to hexadecimal and vice versa
  9. printf with std::string?
  10. How to get rid of `deprecated conversion from string constant to ‘char*’` warnings in GCC?
  11. Difference between string and char[] types in C++
  12. how to check if given c++ string or char* contains only digits?
  13. How do I check if a C++ std::string starts with a certain string, and convert a substring to an int?
  14. Why I cannot cout a string?
  15. What exactly is the L prefix in C++?
  16. reading a line from ifstream into a string variable
  17. Modifying a char *const string
  18. How to append a char to a std::string?
  19. A good example for boost::algorithm::join
  20. How to make my split work only on one real line and be capable to skip quoted parts of string?
  21. Why am I getting string does not name a type Error?
  22. “” + something in C++
  23. What does flushing the buffer mean?
  24. how to check string start in C++
  25. Padding stl strings in C++
  26. Align cout format as table’s columns
  27. How to compare strings
  28. How can a char pointer be initialized with a string (Array of characters) but an int pointer not with an array of integer? [duplicate]
  29. Forcing String to int Function to Consume Entire String
  30. How to get file extension from string in C++

Leave a Comment