Issue with List.Add() only saving the last added item [duplicate]

by

You need to instantiate the Orderables within the for loop; otherwise, you keep reusing the same instance in all iterations (and overwriting its properties each time).

AssociatedComboItems ai = new AssociatedComboItems();
List<Orderables> tempList = new List<Orderables>();

foreach (var t in comboBox1.Items)
{
    ai.ComboBoxItem = t.ToString();

    for (int i = 0; i < fpSpread1.ActiveSheet.RowCount; i++)
    {
        Orderables orderables = new Orderables();  // ← Instantiate here
        orderables.Display = fpSpread1.ActiveSheet.Cells[i, 1].Text;
        orderables.ShowInDSR = (bool)fpSpread1.ActiveSheet.Cells[i, 0].Value;
        orderables.DisplayOrder = i;
        tempList.Add(orderables);
    }

    ai.AssociatedItems = tempList;
    tempList.Clear();
    if(AssociatedItems == null)
    AssociatedItems = new List<AssociatedComboItems>();
    AssociatedItems.Add(ai);
}

Unrelated to the question: You might find object initializer syntax to be cleaner:

Orderables orderables = new Orderables
{
    Display = fpSpread1.ActiveSheet.Cells[i, 1].Text,
    ShowInDSR = (bool)fpSpread1.ActiveSheet.Cells[i, 0].Value,
    DisplayOrder = i,
};

More Related Contents:

  1. Given a filesystem path, is there a shorter way to extract the filename without its extension?
  2. How to create and use resources in .NET
  3. Properly draw text using GraphicsPath
  4. How to draw directly on the Windows desktop, C#?
  5. Nullable vs. int? – Is there any difference?
  6. C# thread safety with get/set
  7. Sum of digits in C#
  8. Why does TimeSpan.ParseExact not work
  9. Uncompressing gzip response from WebClient
  10. How to compare Unicode characters that “look alike”?
  11. C# WinForms ErrorProvider Control
  12. Error “There is already an open DataReader associated with this Command which must be closed first” when using 2 distinct commands
  13. OpenXML SDK having borders for cell
  14. The current .NET SDK does not support targeting .NET Core 2.2. (SDK 2.2.202)
  15. How to ignore ssl_client_socket_impl.cc(1061)] handshake failed in selenium c# ChromeDriver
  16. How can I detect if this dictionary key exists in C#?
  17. Get list of local computer usernames in Windows
  18. C# – How to change PNG quality or color depth
  19. How to find path to .cs file by its type in C#
  20. Get the current user, within an ApiController action, without passing the userID as a parameter
  21. What is the simplest way to run a timer-triggered Azure Function locally once?
  22. VS2015 – Change TypeScript Version
  23. Split string and get first value only
  24. How to lock on an integer in C#?
  25. Create a user defined table type in c# to use in sql server stored procedure
  26. Cast an Anonymous Types in Object and retrieve one Field
  27. C# – Set Directory Permissions for All Users in Windows 7
  28. Formatting DateTime in ASP.NET Core 3.0 using System.Text.Json
  29. How can I read image pixels’ values as RGB into 2d array?
  30. Working example for JavaScriptResult in asp.net mvc

Leave a Comment