Javascript Array value [closed]

by

I think your explanation it is hard to understand. Your are comparing an object with a number after you incremented the type, so conditions won’t met

function checkClick (mouseEvent) {
    for (i = 0; i < all_rails.length; i++) {
        if (mouse_x < all_rails[i].x + 32 && mouse_x > all_rails[i].x && mouse_y >         all_rails[i].y && mouse_y < all_rails[i].y + 32) {
            if (all_rails[i] !== 0) {
                /*
                    Always happens, all_rails[i] is an object, not the number 0
                */
                all_rails[i].type++;  // Always increment
                if (all_rails[i] == 1 && all_rails[i].type > 1) {
                    /*
                        Never happens, all_rails[i] is an object, not a value 1
                    */
                    all_rails[i].type = 0; // Never resets
                }
                else if (all_rails[i] == 2 && all_rails[i].type > 3) {
                    /*
                        Never happens, all_rails[i] is an object, not a value 2
                    */
                    all_rails[i].type = 0; // Never resets
                }
            }
        }
    }
}

You declared all_rails as:

var all_rails = [0, 0, 1, 2, 0, 1, 2, 0, 1, 0, 1, 2, 0, 1, 2, 0, 1, 0, 1, 2, 0, 1, 2, 0, 1, 0, 1, 2, 0, 1, 2, 0, 0, 1, 2, 0, 1, 2, 0, 1, 0, 1, 2, 0, 1, 2, 0, 1, 0, 1, 2, 0, 1, 2, 0, 1, 0, 1, 2, 0, 1, 2, 0, 1,];

but in make_rail you assign an object s_rail or object c_rail to all the items, overriding the initial numerical value.
Available fixes are add a custom valueOf to the c_rail and s_rail objects that evaluates to the initial all_rails[n] value (not recommended) or add a new property that holds the initial numerical value and pass it as an argument to the c_rail and s_rail constructors, then fix checkClick function to compare the property of all_rails[i] rather than the object itself.

(I will also recommend that in JavaScript you declare everything first before you execute actual code. Also to use capitalize the first letter of the constructor and use camel case)

More Related Contents:

  1. Custom/Modified 'Fibonacci' Number sequence
  2. javascript slice without using built in method [closed]
  3. JavaScript code to fetch range of dates from array of objects depending on one attribute of the array using array.reduce()
  4. For-each over an array in JavaScript
  5. Checking if a key exists in a JavaScript object?
  6. How to find the sum of an array of numbers
  7. What is the stability of the Array.sort() method in different browsers?
  8. What is the fastest or most elegant way to compute a set difference using Javascript arrays?
  9. How to initialize an array’s length in JavaScript?
  10. Remove last item from array
  11. Check if object value exists within a Javascript array of objects and if not add a new object to array
  12. How to get subarray from array?
  13. No semicolon before [] is causing error in JavaScript
  14. How do I remove objects from a JavaScript associative array?
  15. Filter strings in Array based on content (filter search value)
  16. How to convert Set to Array?
  17. Declare an empty two-dimensional array in Javascript?
  18. Merge Array of Objects by Property using Lodash
  19. Why does Array.apply(null, [args]) act inconsistently when dealing with sparse arrays?
  20. Extract certain properties from all objects in array
  21. How to get an array of unique values from an array containing duplicates in JavaScript? [duplicate]
  22. Sort an array to have specific items first in the array
  23. Zip arrays in JavaScript?
  24. Lodash create collection from duplicate object keys
  25. Getter/setter on javascript array?
  26. An efficient way to get the difference between two arrays of objects?
  27. Compare two Arrays with Objects and create new array with unmatched objects
  28. Difference between ( for… in ) and ( for… of ) statements?
  29. Find object having maximum value for the `id` property in an array of objects
  30. Why do these two javascript 2d-arrays behave differently?

Leave a Comment