Lint error “Do not treat position as fixed; only use immediately…”

by

The documentation of RecyclerView.Adapter.onBindViewHolder() states:

Note that unlike ListView, RecyclerView will not call this method
again if the position of the item changes in the data set unless the
item itself is invalidated or the new position cannot be determined.
For this reason, you should only use the position parameter while
acquiring the related data item inside this method and should not keep
a copy of it. If you need the position of an item later on (e.g. in a
click listener), use getAdapterPosition() which will have the updated
adapter position

So, technically items may be re-arranged (like sorted, or moved around) and binding will not be necessary because items are not invalidated yet. This means onBindViewHolder() may NOT be called if items show the same data, but just their position/index in a list changes. The position variable received holds true only for the scope of bind function and will not always point to the correct position in the data set. That’s why the function getAdapterPosition() must be called every time updated position is needed.

IMHO, mLastPosition = holder.getAdapterPosition(); is still potentially wrong. Because item may be re-arranged and mLastPosition still points to old position.

About why lint is silent, perhaps Lint’s rule is not that thorough. It’s only checking whether the position parameter is being copied or not.

More Related Contents:

  1. RecyclerView vs. ListView
  2. How to save RecyclerView’s scroll position using RecyclerView.State?
  3. How to animate RecyclerView items when they appear
  4. Saving EditText content in RecyclerView
  5. How to implement multi-select in RecyclerView? [closed]
  6. Permission is only granted to system app
  7. RecyclerView itemClickListener in Kotlin
  8. Changing background color of selected item in recyclerview
  9. How to add Onclick listener to recycler view
  10. Get center visible item of RecycleView when scrolling
  11. Refreshing data in RecyclerView and keeping its scroll position
  12. How can we have searched characters colored when we use searchview in recyclerview?
  13. Adding items to Endless Scroll RecyclerView with ProgressBar at bottom
  14. Expandable list with RecyclerView?
  15. Error inflating class and android.support.v7.widget.CardView
  16. Android recyclerView findViewHolderForAdapterPosition returns null
  17. ViewPager + RecyclerView issue in android
  18. using notifyItemRemoved or notifyDataSetChanged with RecyclerView in Android
  19. RecyclerView steals focus when inside a NestedScrollView
  20. How to set RecyclerView app:layoutManager=”” from XML?
  21. Is there a way to show a preview of a RecyclerView’s contents in the Android Studio editor?
  22. How to create context menu for RecyclerView
  23. Put an indeterminate progressbar as footer in a RecyclerView grid
  24. CoordinatorLayout using the ViewPager’s RecyclerView
  25. How to click on an item inside a RecyclerView in Espresso
  26. RecyclerView items don’t fill width
  27. RecyclerView causes issue when recycling
  28. onCheckedChanged called automatically
  29. Divide elements on groups in RecyclerView
  30. GridLayoutManager – how to auto fit columns?

Leave a Comment