List thread safety

by

No! It is not safe at all, because processed.Add is not. You can do following:

items.AsParallel().Select(item => SomeProcessingFunc(item)).ToList();

Keep in mind that Parallel.ForEach was created mostly for imperative operations for each element of sequence. What you do is map: project each value of sequence. That is what Select was created for. AsParallel scales it across threads in most efficient manner.

This code works correctly:

var processed = new List<Guid>();
Parallel.ForEach(items, item => 
{
    lock(items.SyncRoot)
        processed.Add(SomeProcessingFunc(item));
});

but makes no sense in terms of multithreading. locking at each iteration forces totally sequential execution, bunch of threads will be waiting for single thread.

More Related Contents:

  1. Parallel.ForEach vs Task.Factory.StartNew
  2. When to dispose CancellationTokenSource?
  3. What is the difference between task and thread?
  4. What does MaxDegreeOfParallelism do?
  5. Check if list contains any of another list
  6. ThreadPool.QueueUserWorkItem vs Task.Factory.StartNew
  7. Fastest way to Remove Duplicate Value from a list by lambda
  8. Should i use ThreadPools or Task Parallel Library for IO-bound operations
  9. Difference between List and array when initiating [closed]
  10. Why not inherit from List?
  11. What is the best way to modify a list in a ‘foreach’ loop?
  12. Using async/await for multiple tasks
  13. What are the true benefits of ExpandoObject?
  14. How to get values of selected items in CheckBoxList with foreach in ASP.NET C#?
  15. When should TaskCompletionSource be used?
  16. Adding items to a LIST of objects results in duplicate Objects when using a NEW in a Loop
  17. C# List to string with delimiter
  18. Combination of List
  19. How to create a task (TPL) running a STA thread?
  20. .Contains() on a list of custom class objects
  21. Best way to convert callback-based async method to awaitable task
  22. A list of multiple data types?
  23. How can I prevent synchronous continuations on a Task?
  24. Iterating over JSON object in C#
  25. List size limitation in C#
  26. C# List – Removing items while looping / iterating [duplicate]
  27. How to throttle multiple asynchronous tasks?
  28. TPL Dataflow, whats the functional difference between Post() and SendAsync()?
  29. How to get current working directory path c#?
  30. How to convert c# generic list to json using json.net?

Leave a Comment