Not thread-safe Object publishing

by

The reason why this is possible is that Java has a weak memory model. It does not guarantee ordering of read and writes.

This particular problem can be reproduced with the following two code snippets representing two threads.

Thread 1:

someStaticVariable = new Holder(42);

Thread 2:

someStaticVariable.assertSanity(); // can throw

On the surface it seems impossible that this could ever occur. In order to understand why this can happen, you have to get past the Java syntax and get down to a much lower level. If you look at the code for thread 1, it can essentially be broken down into a series of memory writes and allocations:

  1. Alloc memory to pointer1
  2. Write 42 to pointer1 at offset 0
  3. Write pointer1 to someStaticVariable

Because Java has a weak memory model, it is perfectly possible for the code to actually execute in the following order from the perspective of thread 2:

  1. Alloc Memory to pointer1
  2. Write pointer1 to someStaticVariable
  3. Write 42 to pointer1 at offset 0

Scary? Yes but it can happen.

What this means though is that thread 2 can now call into assertSanity before n has gotten the value 42. It is possible for the value n to be read twice during assertSanity, once before operation #3 completes and once after and hence see two different values and throw an exception.

EDIT

According to Jon Skeet, the AssertionError migh still occur with Java 8 unless the field is final.

More Related Contents:

  1. Is iterating ConcurrentHashMap values thread safe?
  2. Are non-synchronised static methods thread safe if they don’t modify static class variables?
  3. Thread Confinement
  4. Are arrays thread-safe in Java?
  5. Explain the timing causing HashMap.put() to execute an infinite loop
  6. Why is creating a Thread said to be expensive?
  7. Why is i++ not atomic?
  8. Java Wait and Notify: IllegalMonitorStateException
  9. Is java.sql.Connection thread safe?
  10. Are static variables shared between threads?
  11. Java synchronized method lock on object, or method?
  12. How to asynchronously call a method in Java
  13. Should we use EventQueue.invokeLater for any GUI update in a Java desktop application?
  14. Is it safe to get values from a java.util.HashMap from multiple threads (no modification)?
  15. Concurrent threads adding to ArrayList at same time – what happens?
  16. What is thread Safe in java? [duplicate]
  17. Throttling javafx gui updates
  18. Javafx: Difference between javafx.concurent and Platform.runLater?
  19. RxJava instead of AsyncTask?
  20. When should we use Java’s Thread over Executor?
  21. ThreadPoolExecutor Block When its Queue Is Full?
  22. Java ReentrantReadWriteLocks – how to safely acquire write lock when in a read lock?
  23. Concurrent JUnit testing
  24. Whether to use invokeAll or submit – java Executor service
  25. Handling Exceptions for ThreadPoolExecutor
  26. Java Synchronization [closed]
  27. Java 8: Parallel FOR loop
  28. Setting Ideal size of Thread Pool [duplicate]
  29. Threads – Why a Lock has to be followed by try and finally
  30. How to interrupt underlying execution of CompletableFuture

Leave a Comment