Onclick event getting called automatically

by

You’re calling the function right away.

When you leave the parentheses on the function reference, what you’re basically saying is:

Evaluate the closeThis function and assign the result to onclick

when what you really want to do is assign the function reference to the click handler:

document.getElementById("closeButton").onclick = myclassObj.closeThis;

Leave out the parentheses instead, and you’ll bind the closeThis function to the onclick. What this instead says is:

Assign the function closeThis to the click handler.

You are essentially assigning the function to the variable as a first-class object, or a reference to a function.

As an aside, my personal preference is to always use an anonymous function wrapper. Sometimes you need to be able to pass parameters into your function, and this makes sure that you can more easily do so:

document.getElementById("closeButton").onclick = 
    function() {
        myclassObj.closeThis();
    };

More Related Contents:

  1. How to open javascript menu with click & close with mouse out
  2. How to get children id when I click the parent?
  3. Call ASP.NET function from JavaScript?
  4. $(document).click() not working correctly on iPhone. jquery [duplicate]
  5. React onClick function fires on render
  6. onClick not working on mobile (touch)
  7. Why is this jQuery click function not working?
  8. HTML tag want to add both href and onclick working
  9. Onclick event not firing on jsfiddle.net [closed]
  10. Accessing control client name and not ID in ASP.NET
  11. javascript onclick event over flash object
  12. Leaflet- marker click event works fine but methods of the class are undefined in the callback function
  13. javascript get x and y coordinates on mouse click
  14. Detect if button click real user or triggered by a script
  15. Missing click event for inside element on firefox
  16. Call two functions from same onclick [duplicate]
  17. CSS Animation onClick
  18. JavaScript: Invoking click-event of an anchor tag from javascript
  19. javascript onclick happening on page load
  20. Change CSS properties on click
  21. Change Button color onClick
  22. How can I stop an onclick event from firing for parent element when child is clicked?
  23. jQuery function not binding to newly added dom elements
  24. How to add click event to an element?
  25. onClick Function “this” Returns Window Object
  26. How to track a Google Adwords conversion onclick?
  27. Function not calling within an onclick event
  28. JavaScript button onclick not working
  29. onclick calling hide-div function not working
  30. Change text color with Javascript?

Leave a Comment