Properly locking a List in MultiThreaded Scenarios?

by

I will lock on the _myList itself here since it is private, but using a separate variable is more common. To improve on a few points:

public static class MyClass 
{
    private static List<string> _myList = new List<string>;
    private static bool _record; 

    public static void StartRecording()
    {
        lock(_myList)   // lock on the list
        {
           _myList.Clear();
           _record = true;
        }
    }

    public static IEnumerable<string> StopRecording()
    {
        lock(_myList)
        {
          _record = false;
          // Return a Read-Only copy of the list data
          var result = new List<string>(_myList).AsReadOnly();
          _myList.Clear();
          return result;
        }
    }

    public static void DoSomething()
    {
        lock(_myList)
        {
          if(_record) _myList.Add("Test");
        }
        // More, but unrelated actions
    }
}

Note that this code uses lock(_myList) to synchronize access to both _myList and _record. And you need to sync all actions on those two.

And to agree with the other answers here, lock(_myList) does nothing to _myList, it just uses _myList as a token (presumably as key in a HashSet). All methods must play fair by asking permission using the same token. A method on another thread can still use _myList without locking first, but with unpredictable results.

We can use any token so we often create one specially:

private static object _listLock = new object();

And then use lock(_listLock) instead of lock(_myList) everywhere.

This technique would have been advisable if myList had been public, and it would have been absolutely necessary if you had re-created myList instead of calling Clear().

More Related Contents:

  1. What’s wrong with using Thread.Abort()
  2. Run async method regularly with specified interval
  3. How can I set processor affinity to a thread or a Task in .NET?
  4. How to pass parameters to ThreadStart method in Thread?
  5. Why we need Thread.MemoryBarrier()?
  6. The calling thread cannot access this object because a different thread owns it [duplicate]
  7. Updating an ObservableCollection in a separate thread
  8. Does a locked object stay locked if an exception occurs inside it?
  9. Code for a simple thread pool in C# [closed]
  10. Unable to use more than one processor group for my threads in a C# app
  11. Benefits of using async and await keywords
  12. Why does this simple .NET console app have so many threads?
  13. A reproducible example of volatile usage
  14. How to catch exceptions from a ThreadPool.QueueUserWorkItem?
  15. thread with multiple parameters
  16. Difference between lock(locker) and lock(variable_which_I_am_using)
  17. What is the difference between ManualResetEvent and AutoResetEvent in .NET?
  18. Lock (Monitor) internal implementation in .NET
  19. .NET 4.0 and the dreaded OnUserPreferenceChanged Hang
  20. Advantage of using Thread.Start vs QueueUserWorkItem
  21. How do I spawn threads on different CPU cores?
  22. Reading an int that’s updated by Interlocked on other threads
  23. How to get awaitable Thread.Sleep?
  24. Thread parameters being changed
  25. Queue of async tasks with throttling which supports muti-threading
  26. Parallel doesnt work with Entity Framework
  27. ThreadStaticAttribute in ASP.NET
  28. Handling events from out-of-proc COM server in managed STA application
  29. ReaderWriterLock vs lock{}
  30. When exactly does .NET Monitor go to kernel-mode?

Leave a Comment