Puppeteer doesn’t close browser

by

Ahhh! This is a simple oversight. What if an error occurs and your await browser.close() never executes thus leaving you with zombies.

Using shell.js seems to be a hacky way of solving this issue.

The better practice is to use try..catch..finally. The reason being you would want the browser to be closed irrespective of a happy flow or an error being thrown.
And unlike the other code snippet, you don’t have to try and close the browser in the both the catch block and finally block. finally block is always executed irrespective of whether an error is thrown or not.

So, your code should look like,

const puppeteer = require('puppeteer');
const express = require('express');

const router = express.Router();

/* GET home page. */
router.get("https://stackoverflow.com/", function(req, res, next) {
  (async () => {
    const browser = await puppeteer.launch({
      headless: true,
      args: ['--no-sandbox'],
    });

    try {
      const page = await browser.newPage();
      url = req.query.url;
      await page.goto(url);
      const bodyHTML = await page.evaluate(() => document.body.innerHTML);
      res.send(bodyHTML);
    } catch (e) {
      console.log(e);
    } finally {
      await browser.close();
    }
  })();
});

Hope this helps!

More Related Contents:

  1. SyntaxError: Unexpected token function – Async Await Nodejs
  2. Is there a way to wrap an await/async try/catch block to every function?
  3. Async Await map not awaiting async function to complete inside map function before mapping next item
  4. Why I got document is not defined error in puppeteer?
  5. Writing to files in Node.js
  6. Combination of async function + await + setTimeout
  7. Correct Try…Catch Syntax Using Async/Await
  8. What’s wrong with awaiting a promise chain?
  9. Async/Await Class Constructor
  10. How to enable cors nodejs with express?
  11. How to get a URL parameter in Express?
  12. Failed to load c++ bson extension
  13. JavaScript array .reduce with async/await
  14. Async/Await inside Array#map()
  15. Nodejs express and promises not doing what I expect
  16. In JavaScript, does using await inside a loop block the loop?
  17. What does “./bin/www” do in Express 4.x?
  18. ES8 Immediately invoked async function expression
  19. MongoDB select where in array of _id?
  20. res.download() not working in my case
  21. Do Javascript promises block the stack
  22. Listen on HTTP and HTTPS for a single express app
  23. Mongoose stopped accepting callbacks for some of its functions
  24. configure node express to serve static bower_components?
  25. Transpile Async Await proposal with Babel.js?
  26. require(‘babel/register’) doesn’t work
  27. Express: Setting content-type based on path/file?
  28. express.js – how to intercept response.send() / response.json()
  29. Can’t get rid of header X-Powered-By:Express
  30. JS async/await – why does await need async?

Leave a Comment