Removing Item From List – during iteration – what’s wrong with this idiom?

by

Some answers explain why this happens and some explain what you should’ve done. I’ll shamelessly put the pieces together.

What’s the reason for this?

Because the Python language is designed to handle this use case differently. The documentation makes it clear:

It is not safe to modify the sequence being iterated over in the loop (this can only happen for mutable sequence types, such as lists). If you need to modify the list you are iterating over (for example, to duplicate selected items) you must iterate over a copy.

Emphasis mine. See the linked page for more — the documentation is copyrighted and all rights are reserved.

You could easily understand why you got what you got, but it’s basically undefined behavior that can easily change with no warning from build to build. Just don’t do it.

It’s like wondering why i += i++ + ++i does whatever the hell it is it that line does on your architecture on your specific build of your compiler for your language — including but not limited to trashing your computer and making demons fly out of your nose 🙂

How it could this be re-written to remove every item?

  • del letters[:] (if you need to change all references to this object)
  • letters[:] = [] (if you need to change all references to this object)
  • letters = [] (if you just want to work with a new object)

Maybe you just want to remove some items based on a condition? In that case, you should iterate over a copy of the list. The easiest way to make a copy is to make a slice containing the whole list with the [:] syntax, like so:

#remove unsafe commands
commands = ["ls", "cd", "rm -rf /"]
for cmd in commands[:]:
  if "rm " in cmd:
    commands.remove(cmd)

If your check is not particularly complicated, you can (and probably should) filter instead:

commands = [cmd for cmd in commands if not is_malicious(cmd)]

More Related Contents:

  1. Accessing the index in ‘for’ loops
  2. Strange result when removing item from a list while iterating over it
  3. What is the most “pythonic” way to iterate over a list in chunks?
  4. Modifying list while iterating [duplicate]
  5. Iterate through pairs of items in a Python list [duplicate]
  6. How to avoid “RuntimeError: dictionary changed size during iteration” error?
  7. Can’t modify list elements in a loop [duplicate]
  8. Python – TypeError: ‘int’ object is not iterable
  9. How to iterate over a list in chunks
  10. How do I loop through a list by twos? [duplicate]
  11. Assigning values to variables in a list using a loop
  12. python assign values to list elements in loop
  13. How to transform string of space-separated key,value pairs of unique words into a dict
  14. Why do I get “List index out of range” when trying to add consecutive numbers in a list using “for i in list”? [duplicate]
  15. Why does a for-loop with pop-method (or del statement) not iterate over all list elements [duplicate]
  16. Why doesn’t assigning to the loop variable modify the original list? How can I assign back to the list in a loop? [duplicate]
  17. Iterate through adjacent pairs of items in a Python list [duplicate]
  18. How can I avoid “RuntimeError: dictionary changed size during iteration” error?
  19. Loop over 2 lists, repeating the shortest until end of longest [duplicate]
  20. Loop through list with both content and index [duplicate]
  21. Count duplicates between 2 lists
  22. How to find the maximum number in a list using a loop?
  23. Strange result when removing item from a list while iterating over it in Python
  24. Different ways of clearing lists
  25. How to get item’s position in a list?
  26. Complexity of list.index(x) in Python
  27. Nested list comprehensions
  28. Group list by values [duplicate]
  29. What are dict_keys, dict_items and dict_values?
  30. Ordered intersection of two lists in Python

Leave a Comment