Returning from a finally block in Java

by

I had a REALLY hard time to track down a bug years ago that was caused by this. The code was something like:

Object problemMethod() {
    Object rtn = null;
    try {
        rtn = somethingThatThrewAnException();
    }
    finally {
        doSomeCleanup();
        return rtn;
    }
}

What happened is that the exception was thrown down in some other code. It was being caught and logged and rethrown within the somethingThatThrewAnException() method. But the exception wasn’t being propagated up past problemMethod(). After a LONG time of looking at this we finally tracked it down to the return method. The return method in the finally block was basically stopping the exception that happened in the try block from propagating up even though it wasn’t caught.

Like others have said, while it is legal to return from a finally block according to the Java spec, it is a BAD thing and shouldn’t be done.

More Related Contents:

  1. Does a finally block always get executed in Java?
  2. Can we use “return” in finally block [duplicate]
  3. Try-catch-finally and then again a try catch
  4. NumberFormatException not wrking java
  5. How to create exception from another class
  6. How to return multiple objects from a Java method?
  7. Why does writeObject throw java.io.NotSerializableException and how do I fix it?
  8. Multiple returns: Which one sets the final return value?
  9. When to catch java.lang.Error?
  10. Exception in thread “main” java.lang.UnsupportedClassVersionError: a (Unsupported major.minor version 51.0) [duplicate]
  11. Why is the Catch(Exception) almost always a bad Idea?
  12. Difference between java.lang.RuntimeException and java.lang.Exception
  13. How do you implement a re-try-catch?
  14. Is it possible to catch out of memory exception in java? [duplicate]
  15. Throws or try-catch
  16. Why can’t I throw an exception in a Java 8 lambda expression? [duplicate]
  17. Try-with-resources and return statements in java
  18. Mockito test a void method throws an exception
  19. Who is calling the Java Thread interrupt() method if I’m not?
  20. Update JavaFX UI from another thread
  21. How can I print error stack trace in JSP page?
  22. Convert LocalDate in DD/MM/YYYY LocalDate [duplicate]
  23. java.util.ConcurrentModificationException not thrown when expected
  24. Behaviour of return statement in catch and finally
  25. iText/BouncyCastle ClassNotFound org.bouncycastle.asn1.DEREncodable and org.bouncycastle.tsp.TimeStampTokenInfo
  26. Why use finally instead of code after catch [duplicate]
  27. What is the use of printStackTrace() method in Java?
  28. Is it a bad idea to use printStackTrace() for caugt Exceptions?
  29. The local variable might not have been initialized – Detect unchecked exception throw within a method
  30. org.openqa.selenium.UnhandledAlertException: unexpected alert open

Leave a Comment