Segmentation fault, I don’t know why

by

I would recommend you to replace

if(c!=' ' && c!='\t' && c!='\n')

with 

if(!isspace(c))  // Iam easier and more readable

from ctype.h. Which detects all these characters

' '      space 
'\t'     horizontal tab 
'\n'     newline
'\v'     vertical tab 
'\f'     feed 
'\r'     carriage return

Also you should change char*** word_array; (three star general) to pointer to pointer which is enough. Then alloc memory on heap (dynamic storage duration). You didnt do it and it caused segmentaion fault (dereferencing uninitialzed pointer).

char ** word_array = malloc (sizeof(char *) * ROWS);
for (int i = 0; i < ROWS; ++i)
{
    word_array[i] = malloc (sizeof(char) * ROW_LEN);
}

You shouldn’t cast malloc()‘s return value because it may lead to problems.

Also you should check number of rows, and if needed use realloc to get more rows, because accessing out of bounds leads to undefined behavior.

Instead of copying character by character use strcpy, since you know there is enough space. Its more readable and easier.

for(k=0 ; tmp[k] != '\0' ; k++){
    (*word_array)[j][k]=tmp[k];
}

to

strcpy(word_array[j], tmp); // In case word_array is char **

I can see spaces in your string but you arent skiping them, this may help

while ((c=s[id_s++]) && isspace(c))
    ;

More Related Contents:

  1. my code does not work and I don’t know why ;-;
  2. Why do I get a segmentation fault with strcmp [closed]
  3. Crash or “segmentation fault” when data is copied/scanned/read to an uninitialized pointer
  4. Why is this string reversal C code causing a segmentation fault? [duplicate]
  5. How can I allocate memory and return it (via a pointer-parameter) to the calling function?
  6. sprintf() with automatic memory allocation?
  7. What’s the difference between a VLA and dynamic memory allocation via malloc?
  8. How to dynamically allocate memory space for a string and get that string from user?
  9. How is malloc() implemented internally? [duplicate]
  10. Why does this code segfault on 64-bit architecture but work fine on 32-bit?
  11. Should I free memory before exit?
  12. Freaky way of allocating two-dimensional array?
  13. Function to dynamically allocate matrix
  14. Include source code of malloc.c in gdb?
  15. C – Segmentation Fault with strcmp?
  16. Can I rely on malloc returning NULL?
  17. C – Accessing data AFTER memory has been free()ed?
  18. allocate matrix in C
  19. How to initialize const in a struct in C (with malloc)
  20. If free() knows the length of my array, why can’t I ask for it in my own code?
  21. Getting the size of a malloc only with the returned pointer
  22. How do I free memory in C?
  23. SegFault after scanf?
  24. What is the simplest standard conform way to produce a Segfault in C?
  25. Problem usage memory in C
  26. realloc(): invalid next size when reallocating to make space for strcat on char * [duplicate]
  27. Minimizing the amount of malloc() calls improves performance?
  28. strncpy leading to segmentation fault
  29. Malloc and array index confusion in C
  30. zero size malloc [duplicate]

Leave a Comment