Serilog DI in ASP.NET Core, which ILogger interface to inject?

by

Choosing which interface to use within your application is a matter of taste, really. If you prefer Serilog’s ILogger shorter method names (e.g. log.Error vs log.LogError), go with that, otherwise use the Microsoft’s generic ILogger<>. You have control over all the dependencies you use in your own projects, so there’s no strong technical reason to prefer one over the other.

You might be interested in reading this issue on Serilog’s repo:

Should I use Microsoft.Extensions.Logging.ILogger or Serilog.ILogger?.

I personally use Serilog’s ILogger across all my projects not only because I do prefer the shorter method names, but also because I prefer not to inject a logger in every single constructor of every class, and it’s also easy to have a contextual logger for every class using Log.ForContext<>, which is useful when troubleshooting issues. E.g.

public class SomeService
{
    private readonly ILogger _log = Log.ForContext<SomeService>();
    // ...
}

public class SomeRepository
{
    private readonly ILogger _log = Log.ForContext<SomeRepository>();
    // ...
}

If you were developing a library though, I’d recommend using Microsoft’s generic ILogger<>, of course, instead of taking a dependency on Serilog and force consumers of your library to also take a dependency on Serilog.

Log.Logger is thread-safe, thus registering as a singleton as you are doing above is correct if you want all classes to share the same instance (without SourceContexts) – nothing wrong with that.

More Related Contents:

  1. Resolving instances with ASP.NET Core DI from within ConfigureServices
  2. ASP.NET Core Dependency Injection error: Unable to resolve service for type while attempting to activate
  3. .NET Core DI, ways of passing parameters to constructor
  4. Hangfire – Multi tenant, ASP.NET Core – Resolving the correct tenant
  5. What are the costs and possible side effects of calling BuildServiceProvider() in ConfigureServices()
  6. Use DbContext in ASP .Net Singleton Injected Class
  7. Dependency Injection error: Unable to resolve service for type while attempting to activate, while class is registered
  8. Inject service into Action Filter
  9. Unable to resolve service for type while attempting to activate
  10. Dependency injection resolving by name
  11. Dependency injection, inject with parameters
  12. Proper way to register HostedService in ASP.NET Core. AddHostedService vs AddSingleton
  13. Replace service registration in ASP.NET Core built-in DI container?
  14. How do I inject ASP.NET 5 (vNext) user-secrets into my own utility class?
  15. Register AspNetCore 2.1 Identity system with DbContext interface
  16. Dependency Injection with classes other than a Controller class
  17. Filter Serilog logs to different sinks depending on context source?
  18. Get a service in a IServiceCollection extension
  19. .net Core Quartz Dependency Injection
  20. Dependency Injection in attributes
  21. Return View as String in .NET Core
  22. bypass invalid SSL certificate in .net core
  23. How to mock an async repository with Entity Framework Core
  24. Automatic native and managed DLLs extracting from Nuget Package
  25. Send HTTP POST message in ASP.NET Core using HttpClient PostAsJsonAsync
  26. Cannot consume scoped service IMongoDbContext from singleton IActiveUsersService after upgrade to ASP.NET Core 2.0
  27. ASP.NET Core Get Json Array using IConfiguration
  28. Setting the version number for .NET Core projects – CSPROJ – not JSON projects
  29. Identity UI no longer works after switching to .net core 3 endpoint routing
  30. Bind Dictionary with list in viewmodel to checkboxes

Leave a Comment