Should I always disconnect event handlers in the Dispose method?

by

Unless you expect the publisher of the event to outlive the subscriber, there’s no reason to remove the event handler, no.

This is one of those topics where folk lore has grown up. You really just need to think about it in normal terms: the publisher (e.g. the button) has a reference to the subscriber. If both the publisher and the subscriber will be eligible for garbage collection at the same time anyway (as is common) or if the publisher will be eligible for garbage collection earlier, then there’s no GC issue.

Static events cause a GC problem because they’re effectively an infinitely-long-lived publisher – I would discourage static events entirely, where possible. (I very rarely find them useful.)

The other possible issue is if you explicitly want to stop listening for events because your object will misbehave if the event is raised (e.g. it will try to write to a closed stream). In that case, yes, you should remove the handler. That’s most likely to be in the case where your class implements IDisposable already. It would be unusual – though not impossible – for it to be worth implementing IDisposable just to remove event handlers.

More Related Contents:

  1. Understanding events and event handlers in C#
  2. How would it be possible to remove all event handlers of the ‘Click’ event of a ‘Button’?
  3. Do event handlers stop garbage collection from occurring?
  4. Should I avoid ‘async void’ event handlers?
  5. Do you need to dispose of objects and set them to null?
  6. Is it bad to not unregister event handlers?
  7. BackgroundWorker RunWorkerCompleted Event
  8. What is the difference between using IDisposable vs a destructor in C#?
  9. How do I Unregister ‘anonymous’ event handler [duplicate]
  10. Disposing WPF User Controls
  11. Dispose, when is it called?
  12. Assigning events in object initializer
  13. Weak event handler model for use with lambdas
  14. How do I execute code AFTER a form has loaded?
  15. How to ensure an event is only subscribed to once
  16. A reusable pattern to convert event into task
  17. Single click edit in WPF DataGrid
  18. Does garbage collector call Dispose()? [duplicate]
  19. How to pass an event to a method?
  20. Event Signature in .NET — Using a Strong Typed ‘Sender’? [closed]
  21. Difference between the KeyDown Event, KeyPress Event and KeyUp Event in Visual Studio
  22. Are C# events synchronous?
  23. Difference between destructor, dispose and finalize method
  24. How is this possible: OnPaint processed while in WaitOne
  25. How can I clear event subscriptions in C#?
  26. Handling end process of a windows app
  27. Avoiding the woes of Invoke/BeginInvoke in cross-thread WinForm event handling?
  28. Subscribe to INotifyPropertyChanged for nested (child) objects
  29. What event catches a change of value in a combobox in a DataGridViewCell?
  30. Is it necessary to dispose System.Timers.Timer if you use one in your application?

Leave a Comment